Repository navigation
TernaryToNullCoalescingRector strips unrelated () and breaks the code #8910
Description
Hi there!
I found an edge case, where TernaryToNullCoalescingRector strips a set of () and breaks the code.
$a = null;
$b = 2;
-$m = isset($a) ? $a : ('R' . ($b == 1? '' : 'ector'));
+$m = $a ?? ('R' . $b == 1? '' : 'ector');
var_dump($m);The original version outputs:
string(6) "Rector"
while the proposed version:
string(5) "ector"
Config (rector.php):
<?php
use Rector\Config\RectorConfig;
use Rector\Set\ValueObject\LevelSetList;
use Rector\ValueObject\PhpVersion;
return RectorConfig::configure()
->withSets([
LevelSetList::UP_TO_PHP_84,
])
// demonstrate specific PHP version
->withPhpVersion(PhpVersion::PHP_84);Demo: https://getrector.com/demo/1f14af48-9e91-4a05-9822-a1c18048bd7e
Metadata
Metadata
Assignees
Labels
No labels
Activity
[-]TernaryToNullCoalescingRector strips `()` and breaks the code[/-][+]TernaryToNullCoalescingRector strips unrelated `()` and breaks the code[/+]samsonasik commentedon Nov 4, 2026
I created PR:
for it.