Run cheap guards before expensive analysis calls - #519
Merged
Conversation
Move cheap early-return guards (isName, isNames, isFirstClassCallable) before expensive type analysis calls (getType, isObjectType) in 5 rules. Claude-Session: https://claude.ai/code/session_01Na4eYvNqa2pdhZrBXbegrv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
symplify/phpstan-rules 14.13.0 adds
RectorCheaperGuardsFirstRule, which flags a cheap early-return guard (isName(),isNames(),isFirstClassCallable(), ...) that runs after an expensive analysis call (getType(),isObjectType(), ...) when the cheap guard does not depend on the expensive call's result.This reorders 5 rules so the cheap, independent guards run first and short-circuit before the expensive type resolution:
ExtractArrayArgOnQueryBuilderSelectRectorMigrateQueryBuilderResetQueryPartRectorChangeCompositeExpressionAddMultipleWithWithRectorIterateToToIterableRectorSetParametersArrayToCollectionRectorBehavior-preserving: all guards only
return null, so their relative order does not change the result. PHPStan, ECS, and the affected rule tests pass.