Repository navigation
chore: View.vue の style ブロックを Tailwind に置き換える - #187
Merged
Merged
Conversation
Same values as the stylesheet had; the rules for the table XLSX renders become arbitrary variants on its container, so nothing moves to a global stylesheet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
CODEX VERDICT: LGTM
Read sha: Verification run: FINDINGS COMPLETE: I read every hunk of the diff and this is every finding I have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
View.vue's<style scoped>block with Tailwind classes. This clears scoria'sui-token/style-blockfinding. The look does not change.text-[0.9em],bg-[#217346]and the like).v-html) gets its styling from arbitrary variants on its container:[&_td]:…,[&_tr:nth-child(even)]:…,[&_.cell-editing]:…. Nothing goes into a global stylesheet.:deep()rules were scoped to this component. Putting them in a global stylesheet could have hit a host's own.table-container, which is why they stay on the container.src/vue/viewClasses.ts: the table, the sheet tabs, the editor, the buttons and the mini editor's inputs.group-open:fordetails[open] summary,placeholder:,focus:anddisabled:.Items to Confirm
origin/main) and new demos were opened in Chromium (playwright-core) and the computed styles of every element under the View component compared, in every state:summaryhovered; the textarea and the inputs focused; a cell clicked (green editing highlight); a formula cell clicked (orange referenced-cell highlight); the radio switched; ✕ hovered; Apply enabled and hovered; two sheets applied; a tab hovered; the second tab.border-collapse,transitionand the like.outline-styleitself isnonein both.!important. It and the alternate rows' colour have the same specificity, so which one wins would depend on the order Tailwind writes them in. Marking hover important makes the old order (hover wins) certain.yarn lint,yarn typecheck,yarn build,yarn testandyarn test:enginepass.dist/style.csscontains the new classes, as the build writes them.View.vue'sgod-file(over 500 lines). This change makes the file shorter, but not under the limit.User Prompt
🤖 Generated with Claude Code
work in GUIChatPluginSpreadsheet