Repository navigation
Add imports_at_top rule - #6951
Open
udithaAnuranjana wants to merge 1 commit into
Open
udithaAnuranjana wants to merge 1 commit into
udithaAnuranjana wants to merge 1 commit into
Conversation
Generated by 🚫 Danger |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new opt-in
imports_at_topstyle rule that requires file-scope imports to appear before other declarations.This addresses #6892, where
sorted_importscan sort import groups but does not report imports placed after other code.Behavior
The rule:
@testableimports at the beginning of a file.#if,#elseif, and#else.Example violation:
Leading conditional imports remain valid:
Implementation
ImportsAtTopRuleas an opt-in SwiftSyntax style rule.importkeyword.make register.Testing
swift test --filter ImportsAtTopRuleGeneratedTestsswift testFull test suite: 1113 tests in 378 suites passed.
Closes #6892.