Update to build cew with espeak-ng#258
Conversation
Also fix spurious warning messages that occur for at least python 3.8.
…ebianPackage-20200402 Add package for python3-aeneas
danielbair
left a comment
danielbair
left a comment
There was a problem hiding this comment.
The debian changes are not mine...
|
espeak-ng installer for windows can be downloaded from their repository. espeak-ng for mac is available from MacPorts and HomeBrew (from my homebrew-tap). |
|
@danielbair is this PR still relevant / needed / desired ? |
|
On linux the espeak-ng packages provide a full replacement for espeak. But on Windows and Mac the espeak-ng package doesn't provide full espeak replacement files. So this PR does help Mac and Windows use espeak-ng with cew. I am implementing this PR when building the AIO installer, but this would allow others to benefit from this for installing via other methods. |
|
On Arch linux it looks like |
abathur
left a comment
abathur
left a comment
There was a problem hiding this comment.
I can't speak to this changeset broadly, but I can at least note that the changes in b80b1ca helped me build aeneas with cew support via Nix.
(The espeak package in nixpkgs isn't buildable on macOS since it hasn't been patched to disable the async feature as homebrew does. I wasn't sure about the consequences of patching the feature out, so I decided to try the espeak-ng approach first...)
|
@danielbair is this PR still relevant / needed / desired ? |
|
This was necessary to build cew with espeak-ng. Unless you have made some similar changes, then yes. |
|
@danielbair This branch has conflicts (probably due to some of the merges I did today). Can you please take care of updating this PR, please? Then I will merge it in into FYI I decided that the next version will v1.8.0 --- with the fixes and changes accumulated so far, mostly so that aeneas installs on modern versions of its dependencies (chiefly, Python, NumPy, espeak-ng). |
|
The only conflict was in the debian/changelog which has the latest version listed as 1.7.4 (but you are stating that the next will be 1.8.0 so that will probably need to be changed.) |
Added `import sys` per comment readbeyond@b80b1ca#r1359734746
Updated to current year.
|
This can be merged now. |
6 participants
Tested on windows and mac.
Set AENEAS_USE_ESPEAKNG=True to build cew with espeak-ng