Fix git+ssh repository URLs so Node 26 can run yarn build - #4071
Draft
ntucker wants to merge 1 commit into
Draft
Conversation
SCP-style git+ssh://git@github.com:org/repo.git is not a valid WHATWG URL. Node 26's url.parse() throws ERR_INVALID_ARG_VALUE (Invalid port), which breaks npm-run-all (run-s) during yarn build:bundle. Co-authored-by: natmaster <natmaster@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Size Change: 0 B Total Size: 81 kB ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4071 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 156 156
Lines 3057 3057
Branches 612 612
=======================================
Hits 2991 2991
Misses 18 18
Partials 48 48 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes environment build bld-20260814-c311fca4-2c8f-43f8-ae7b-caecb63b847d (
INSTALL_FAILED).Motivation
Cloud Agent install runs
nvm install(Node 26 from.nvmrc) thenyarn build. That build failed in@data-client/normalizrand@data-client/endpoint:Package
repository.urlvalues used the SCP-style colon (github.com:org/repo). Node 26'surl.parse()treats the segment after:as a port and throwsERR_INVALID_ARG_VALUE.npm-run-all(run-sviayarn g:runs) parses each package.json duringbuild:bundle, so the workspace build exits 1.CircleCI uses
ci:build*(babel/types only), so this did not show up in PR CI. Node 22 only deprecates the same URL (DEP0170).Solution
Use the WHATWG-valid git+ssh form in every published package:
git+ssh://git@github.com/reactive/data-client.git(slash after the host, matching
@anansi/generator-js). No environment install-script change is required once this is on the default branch.Verification
On Node 26.7.0 (same as the failed build):
url.parse('git+ssh://git@github.com:reactive/data-client.git')throws the exact install errorurl.parse('git+ssh://git@github.com/reactive/data-client.git')succeedsyarn workspace @data-client/normalizr run build:bundleand the endpoint equivalent succeedyarn buildcompletes in 53s (the step that exited 1 in the environment install)Open questions
None. Recurring environment builds of
masterwill keep failing until this merges.