Skip to content

add a mapping ability to the interpolate method#7699

Closed
rocman wants to merge 3 commits into
react:masterfrom
world-wide-web:mapping-on-interpolate
Closed

add a mapping ability to the interpolate method#7699
rocman wants to merge 3 commits into
react:masterfrom
world-wide-web:mapping-on-interpolate

Conversation

@rocman

@rocman rocman commented May 23, 2016

Copy link
Copy Markdown
Contributor

This makes it possible to do the interpolation on properties of any type. For example, the contentOffset of a ScrollView.

@ghost

ghost commented May 23, 2016

Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @lelandrichardson and @vjeux to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 23, 2016
@ghost

ghost commented May 23, 2016

Copy link
Copy Markdown

@rocman updated the pull request.

@rocman

rocman commented May 25, 2016

Copy link
Copy Markdown
Contributor Author

@fatihict big thanks for your reviewing. The change you mentioned above is a mistake. And I've fixed it just now. Thanks.

@ghost

ghost commented May 25, 2016

Copy link
Copy Markdown

@rocman updated the pull request.

@lelandrichardson

Copy link
Copy Markdown
Contributor

An API like this won't be compatible with native animations, unfortunately. I wonder if there is any way we could make it so that it would be?

Have to run right now, but will look at this PR a bit more and think about it. You may want to look at this PR for comparison, which could achieve something similar: animatedjs/animated#12

@ghost

ghost commented Jun 24, 2016

Copy link
Copy Markdown

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @lelandrichardson as a potential reviewer. Could you take a look please or cc someone with more context?

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2016
@mkonicek

mkonicek commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

@rocman I'm going through all pull requests and noticed this one hasn't been updated in a while and the last comment mentions:

An API like this won't be compatible with native animations, unfortunately. I wonder if there is any way we could make it so that it would be?

I'll close this pull request so it doesn't stay open indefinitely but please send a new one if you want to continue working on this.

@mkonicek mkonicek closed this Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants