Skip to content

Assert switch state before the toggled visual screenshot - #59413

Open
robhogan wants to merge 1 commit into
mainfrom
robhogan/visual-switch-checked
Open

robhogan wants to merge 1 commit into
mainfrom
robhogan/visual-switch-checked

Conversation

@robhogan

Copy link
Copy Markdown
Collaborator

The custom-colors switch flow takes its toggled screenshot without checking the taps landed, so a dropped tap captures the wrong state. That spoiled a baseline on main and failed #59390.

This asserts each switch's checked state before the screenshot, so a dropped tap fails the flow and it's retried instead.

Changelog: [Internal]

Test plan:
Ran the section on the iOS 26 visual simulator: passes as written, and fails when asserting the wrong state. Android runs in this PR's CI.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 23, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant