Skip to content

Skip image-paste pasteboard probe in TextInput to avoid main-thread hangs #59374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cortinico wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

Skip image-paste pasteboard probe in TextInput to avoid main-thread hangs #59374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/react-native/Libraries/Text/TextInput/Multiline/RCTUITextView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,15 @@ - (BOOL)canPerformAction:(SEL)action withSender:(id)sender
return [super canPerformAction:action withSender:sender];
}

// UIKit queries this when the keyboard becomes active, including when the app returns to the
// foreground. The default implementation calls `canPerformAction:` with `paste:`, which
// synchronously queries the system pasteboard on the main thread and can hang the app. TextInput
// only accepts text, so opt out of image paste; text paste is unaffected.
- (BOOL)supportsImagePaste
{
return NO;
}

- (void)buildMenuWithBuilder:(id<UIMenuBuilder>)builder
{
#if defined(__IPHONE_OS_VERSION_MAX_ALLOWED) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 170000 && !TARGET_OS_TV
Expand Down
9 changes: 9 additions & 0 deletions packages/react-native/Libraries/Text/TextInput/Singleline/RCTUITextField.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,15 @@ - (BOOL)canPerformAction:(SEL)action withSender:(id)sender
return [super canPerformAction:action withSender:sender];
}

// UIKit queries this when the keyboard becomes active, including when the app returns to the
// foreground. The default implementation calls `canPerformAction:` with `paste:`, which
// synchronously queries the system pasteboard on the main thread and can hang the app. TextInput
// only accepts text, so opt out of image paste; text paste is unaffected.
- (BOOL)supportsImagePaste
{
return NO;
}

- (void)buildMenuWithBuilder:(id<UIMenuBuilder>)builder
{
#if defined(__IPHONE_OS_VERSION_MAX_ALLOWED) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 170000
Expand Down
Loading