Repository navigation
Fix TextInput outline collapsing below theme default padding - #59372
Open
mehulg-meta wants to merge 1 commit into
Open
mehulg-meta wants to merge 1 commit into
mehulg-meta wants to merge 1 commit into
Conversation
Summary: TextInput keeps the theme's default EditText background but applies the style's padding. That background is an inset around underline nine-patches, so its outline is the view bounds minus the insets, which only the theme padding covers. With less padding, such as `padding: 0`, the outline collapses to a strip through the text, which breaks elevation shadows and anything else that reads the view outline. `ReactEditText` now uses its bounds as the outline in that case, and refreshes the outline when its padding changes, since Android only does so on size and background changes. Any other background, including the ones React Native creates for border and background styles, keeps its normal outline. Changelog: [Android][Fixed] - Fix `TextInput` outline collapsing when its padding is below the theme default Differential Revision: D126540563
meta-cla
Bot
added
the
CLA Signed
|
@mehulg-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126540563. |
Visual regressionNo visual differences at android: no baseline for this environment ios: no capture |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
TextInput keeps the theme's default EditText background but applies the style's padding. That background is an inset around underline nine-patches, so its outline is the view bounds minus the insets, which only the theme padding covers. With less padding, such as
padding: 0, the outline collapses to a strip through the text, which breaks elevation shadows and anything else that reads the view outline.ReactEditTextnow uses its bounds as the outline in that case, and refreshes the outline when its padding changes, since Android only does so on size and background changes. Any other background, including the ones React Native creates for border and background styles, keeps its normal outline.Changelog:
[Android][Fixed] - Fix
TextInputoutline collapsing when its padding is below the theme defaultDifferential Revision: D126540563