Repository navigation
Conversation
Summary: On Android, `JavaTimerManager` stops JS timers on `onHostPause` and only restarts them on `onHostResume` or while a headless JS task is active. When the app keeps using the JS runtime without a resumed React screen, pending `setTimeout`s and Promise-driven work that depends on them stall until a React screen resumes. On iOS, `RCTTiming` does not depend on host lifecycle: timers keep firing until the instance is invalidated. Add `keepTimersRunningWhileHostPausedAndroid` (default `false`). When enabled, `JavaTimerManager`: - starts the timer frame callback when it is created, since the host may never resume; - stops timers only once the instance is destroyed (tracked by a new `isDestroyed`), instead of when the host is paused. Changelog: [Internal] Differential Revision: D126948111
meta-cla
Bot
added
the
CLA Signed
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126948111. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On Android,
JavaTimerManagerstops JS timers ononHostPauseand only restarts them ononHostResumeor while a headless JS task is active. When the app keeps using the JS runtime without a resumed React screen, pendingsetTimeouts and Promise-driven work that depends on them stall until a React screen resumes. On iOS,RCTTimingdoes not depend on host lifecycle: timers keep firing until the instance is invalidated.Add
keepTimersRunningWhileHostPausedAndroid(defaultfalse). When enabled,JavaTimerManager:isDestroyed), instead of when the host is paused.Changelog: [Internal]
Differential Revision: D126948111