Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
huntie
changed the title
facebook-github-tools
Bot
added
the
Shared with Meta
|
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D126065356. |
Collaborator
|
This pull request was successfully merged by @huntie in 213148b When will my fix make it into a release? | How to file a pick request? |
|
@fabriziocucci merged this pull request in 213148b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fantom tests run with
Platform.OS === 'android'and have no iOS target, which the guide does not say, so an agent asked to test an iOS-only JavaScript branch writes a Fantom test that can never exercise it. Add that to theyarn fantomrow, pointing at Jest for such branches.Changelog: [Internal]
Test Plan:
Docs only. Rendered the table in a Markdown preview.