Repository navigation
Conversation
Summary: Prepared text layouts used `Layout.text` for both rendering and semantic consumers. Android replaces that text with an ellipsis and filler characters when the layout is truncated, causing accessibility services and view hierarchy tools to lose the full logical string. Retain the source `Spanned` text alongside the display `Layout` and preserve it through layout reuse and stateful-span proxying. Semantic consumers now receive the full source text, while drawing, touch handling, and hit testing continue to use the display-shaped layout text. Changelog: [Android][Fixed] - Preserve full semantic text for ellipsized prepared text layouts Differential Revision: D125246577
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125246577. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Prepared text layouts used
Layout.textfor both rendering and semantic consumers. Android replaces that text with an ellipsis and filler characters when the layout is truncated, causing accessibility services and view hierarchy tools to lose the full logical string.Retain the source
Spannedtext alongside the displayLayoutand preserve it through layout reuse and stateful-span proxying. Semantic consumers now receive the full source text, while drawing, touch handling, and hit testing continue to use the display-shaped layout text.Changelog:
[Android][Fixed] - Preserve full semantic text for ellipsized prepared text layouts
Differential Revision: D125246577