Skip to content

Turn off @babel/plugin-transform-destructuring plugin #58965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
retyui wants to merge 2 commits into from
+140 −240
Closed

Turn off @babel/plugin-transform-destructuring plugin #58965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c1ae5f
Modify preserveDestructuring default behavior
retyui Oct 19, 2026
2219007
chore: Update tests
retyui Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions packages/react-native-babel-preset/src/__tests__/__fixtures__/output/hermes-canary-dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ exports.safeJsonParse = safeJsonParse;
exports.sumPairs = sumPairs;
var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits"));
var _setPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/setPrototypeOf"));
var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
var _asyncToGenerator2 = _interopRequireDefault(require("@babel/runtime/helpers/asyncToGenerator"));
var _classPrivateFieldLooseBase2 = _interopRequireDefault(require("@babel/runtime/helpers/classPrivateFieldLooseBase"));
var _classPrivateFieldLooseKey2 = _interopRequireDefault(require("@babel/runtime/helpers/classPrivateFieldLooseKey"));
Expand Down Expand Up @@ -153,8 +152,9 @@ function processUser({
age = 18,
...rest
}) {
var _rest$city = rest.city,
city = _rest$city === void 0 ? 'Unknown' : _rest$city;
var {
city = 'Unknown'
} = rest;
return `${name} (${age}) from ${city}`;
}
function mergeConfigs(base, ...overrides) {
Expand All @@ -169,10 +169,7 @@ function mergeConfigs(base, ...overrides) {
function sumPairs(pairs) {
var total = 0;
for (var _iterator = _createForOfIteratorHelperLoose(pairs), _step; !(_step = _iterator()).done;) {
var _ref = _step.value;
var _ref2 = (0, _slicedToArray2.default)(_ref, 2);
var a = _ref2[0];
var b = _ref2[1];
var [a, b] = _step.value;
total += a + b;
}
return total;
Expand Down Expand Up @@ -236,14 +233,8 @@ var LegacyComponent = exports.LegacyComponent = React.createClass({
function ModernComponent({
initialCount = 0
}) {
var _useState = (0, _react.useState)(initialCount),
_useState2 = (0, _slicedToArray2.default)(_useState, 2),
count = _useState2[0],
setCount = _useState2[1];
var _useState3 = (0, _react.useState)(Status.Active),
_useState4 = (0, _slicedToArray2.default)(_useState3, 2),
status = _useState4[0],
setStatus = _useState4[1];
var [count, setCount] = (0, _react.useState)(initialCount);
var [status, setStatus] = (0, _react.useState)(Status.Active);
(0, _react.useEffect)(() => {
var timer = setInterval(() => {
setCount(c => c + 1);
Expand All @@ -261,12 +252,12 @@ function ModernComponent({
return _handleAsyncClick.apply(this, arguments);
}
var handleClick = function () {
var _ref3 = (0, _asyncToGenerator2.default)(function* () {
var _ref = (0, _asyncToGenerator2.default)(function* () {
yield handleAsyncClick();
setStatus(Status.Pending);
});
return function handleClick() {
return _ref3.apply(this, arguments);
return _ref.apply(this, arguments);
};
}();
return (0, _jsxRuntime.jsxs)("div", {
Expand Down
25 changes: 8 additions & 17 deletions packages/react-native-babel-preset/src/__tests__/__fixtures__/output/hermes-canary-prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ exports.safeJsonParse = safeJsonParse;
exports.sumPairs = sumPairs;
var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits"));
var _setPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/setPrototypeOf"));
var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
var _asyncToGenerator2 = _interopRequireDefault(require("@babel/runtime/helpers/asyncToGenerator"));
var _classPrivateFieldLooseBase2 = _interopRequireDefault(require("@babel/runtime/helpers/classPrivateFieldLooseBase"));
var _classPrivateFieldLooseKey2 = _interopRequireDefault(require("@babel/runtime/helpers/classPrivateFieldLooseKey"));
Expand Down Expand Up @@ -148,8 +147,9 @@ function processUser({
age = 18,
...rest
}) {
var _rest$city = rest.city,
city = _rest$city === void 0 ? 'Unknown' : _rest$city;
var {
city = 'Unknown'
} = rest;
return `${name} (${age}) from ${city}`;
}
function mergeConfigs(base, ...overrides) {
Expand All @@ -163,10 +163,7 @@ function mergeConfigs(base, ...overrides) {
}
function sumPairs(pairs) {
var total = 0;
for (var _ref of pairs) {
var _ref2 = (0, _slicedToArray2.default)(_ref, 2);
var a = _ref2[0];
var b = _ref2[1];
for (var [a, b] of pairs) {
total += a + b;
}
return total;
Expand Down Expand Up @@ -230,14 +227,8 @@ var LegacyComponent = exports.LegacyComponent = React.createClass({
function ModernComponent({
initialCount = 0
}) {
var _useState = (0, _react.useState)(initialCount),
_useState2 = (0, _slicedToArray2.default)(_useState, 2),
count = _useState2[0],
setCount = _useState2[1];
var _useState3 = (0, _react.useState)(Status.Active),
_useState4 = (0, _slicedToArray2.default)(_useState3, 2),
status = _useState4[0],
setStatus = _useState4[1];
var [count, setCount] = (0, _react.useState)(initialCount);
var [status, setStatus] = (0, _react.useState)(Status.Active);
(0, _react.useEffect)(() => {
var timer = setInterval(() => {
setCount(c => c + 1);
Expand All @@ -255,12 +246,12 @@ function ModernComponent({
return _handleAsyncClick.apply(this, arguments);
}
var handleClick = function () {
var _ref3 = (0, _asyncToGenerator2.default)(function* () {
var _ref = (0, _asyncToGenerator2.default)(function* () {
yield handleAsyncClick();
setStatus(Status.Pending);
});
return function handleClick() {
return _ref3.apply(this, arguments);
return _ref.apply(this, arguments);
};
}();
return (0, _jsxRuntime.jsxs)("div", {
Expand Down
25 changes: 8 additions & 17 deletions packages/react-native-babel-preset/src/__tests__/__fixtures__/output/hermes-legacy-dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ exports.processUser = processUser;
exports.safeJsonParse = safeJsonParse;
exports.sumPairs = sumPairs;
var _setPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/setPrototypeOf"));
var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
var _possibleConstructorReturn2 = _interopRequireDefault(require("@babel/runtime/helpers/possibleConstructorReturn"));
var _getPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/getPrototypeOf"));
var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits"));
Expand Down Expand Up @@ -183,8 +182,9 @@ function processUser({
age = 18,
...rest
}) {
var _rest$city = rest.city,
city = _rest$city === void 0 ? 'Unknown' : _rest$city;
var {
city = 'Unknown'
} = rest;
return `${name} (${age}) from ${city}`;
}
function mergeConfigs(base, ...overrides) {
Expand All @@ -198,10 +198,7 @@ function mergeConfigs(base, ...overrides) {
}
function sumPairs(pairs) {
var total = 0;
for (var _ref of pairs) {
var _ref2 = (0, _slicedToArray2.default)(_ref, 2);
var a = _ref2[0];
var b = _ref2[1];
for (var [a, b] of pairs) {
total += a + b;
}
return total;
Expand Down Expand Up @@ -263,14 +260,8 @@ var LegacyComponent = exports.LegacyComponent = React.createClass({
function ModernComponent({
initialCount = 0
}) {
var _useState = (0, _react.useState)(initialCount),
_useState2 = (0, _slicedToArray2.default)(_useState, 2),
count = _useState2[0],
setCount = _useState2[1];
var _useState3 = (0, _react.useState)(Status.Active),
_useState4 = (0, _slicedToArray2.default)(_useState3, 2),
status = _useState4[0],
setStatus = _useState4[1];
var [count, setCount] = (0, _react.useState)(initialCount);
var [status, setStatus] = (0, _react.useState)(Status.Active);
(0, _react.useEffect)(() => {
var timer = setInterval(() => {
setCount(c => c + 1);
Expand All @@ -288,12 +279,12 @@ function ModernComponent({
return _handleAsyncClick.apply(this, arguments);
}
var handleClick = function () {
var _ref3 = (0, _asyncToGenerator2.default)(function* () {
var _ref = (0, _asyncToGenerator2.default)(function* () {
yield handleAsyncClick();
setStatus(Status.Pending);
});
return function handleClick() {
return _ref3.apply(this, arguments);
return _ref.apply(this, arguments);
};
}();
return (0, _jsxRuntime.jsxs)("div", {
Expand Down
25 changes: 8 additions & 17 deletions packages/react-native-babel-preset/src/__tests__/__fixtures__/output/hermes-legacy-prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ exports.processUser = processUser;
exports.safeJsonParse = safeJsonParse;
exports.sumPairs = sumPairs;
var _setPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/setPrototypeOf"));
var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
var _possibleConstructorReturn2 = _interopRequireDefault(require("@babel/runtime/helpers/possibleConstructorReturn"));
var _getPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/getPrototypeOf"));
var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits"));
Expand Down Expand Up @@ -182,8 +181,9 @@ function processUser({
age = 18,
...rest
}) {
var _rest$city = rest.city,
city = _rest$city === void 0 ? 'Unknown' : _rest$city;
var {
city = 'Unknown'
} = rest;
return `${name} (${age}) from ${city}`;
}
function mergeConfigs(base, ...overrides) {
Expand All @@ -197,10 +197,7 @@ function mergeConfigs(base, ...overrides) {
}
function sumPairs(pairs) {
var total = 0;
for (var _ref of pairs) {
var _ref2 = (0, _slicedToArray2.default)(_ref, 2);
var a = _ref2[0];
var b = _ref2[1];
for (var [a, b] of pairs) {
total += a + b;
}
return total;
Expand Down Expand Up @@ -262,14 +259,8 @@ var LegacyComponent = exports.LegacyComponent = React.createClass({
function ModernComponent({
initialCount = 0
}) {
var _useState = (0, _react.useState)(initialCount),
_useState2 = (0, _slicedToArray2.default)(_useState, 2),
count = _useState2[0],
setCount = _useState2[1];
var _useState3 = (0, _react.useState)(Status.Active),
_useState4 = (0, _slicedToArray2.default)(_useState3, 2),
status = _useState4[0],
setStatus = _useState4[1];
var [count, setCount] = (0, _react.useState)(initialCount);
var [status, setStatus] = (0, _react.useState)(Status.Active);
(0, _react.useEffect)(() => {
var timer = setInterval(() => {
setCount(c => c + 1);
Expand All @@ -287,12 +278,12 @@ function ModernComponent({
return _handleAsyncClick.apply(this, arguments);
}
var handleClick = function () {
var _ref3 = (0, _asyncToGenerator2.default)(function* () {
var _ref = (0, _asyncToGenerator2.default)(function* () {
yield handleAsyncClick();
setStatus(Status.Pending);
});
return function handleClick() {
return _ref3.apply(this, arguments);
return _ref.apply(this, arguments);
};
}();
return (0, _jsxRuntime.jsxs)("div", {
Expand Down
21 changes: 6 additions & 15 deletions ...native-babel-preset/src/__tests__/__fixtures__/output/hermes-stable-dev-preserve-async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ exports.safeJsonParse = safeJsonParse;
exports.sumPairs = sumPairs;
var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits"));
var _setPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/setPrototypeOf"));
var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
var _classPrivateFieldLooseBase2 = _interopRequireDefault(require("@babel/runtime/helpers/classPrivateFieldLooseBase"));
var _classPrivateFieldLooseKey2 = _interopRequireDefault(require("@babel/runtime/helpers/classPrivateFieldLooseKey"));
var _react = _interopRequireWildcard(require("react"));
Expand Down Expand Up @@ -136,8 +135,9 @@ function processUser({
age = 18,
...rest
}) {
var _rest$city = rest.city,
city = _rest$city === void 0 ? 'Unknown' : _rest$city;
var {
city = 'Unknown'
} = rest;
return `${name} (${age}) from ${city}`;
}
function mergeConfigs(base, ...overrides) {
Expand All @@ -152,10 +152,7 @@ function mergeConfigs(base, ...overrides) {
function sumPairs(pairs) {
var total = 0;
for (var _iterator = _createForOfIteratorHelperLoose(pairs), _step; !(_step = _iterator()).done;) {
var _ref = _step.value;
var _ref2 = (0, _slicedToArray2.default)(_ref, 2);
var a = _ref2[0];
var b = _ref2[1];
var [a, b] = _step.value;
total += a + b;
}
return total;
Expand Down Expand Up @@ -213,14 +210,8 @@ var LegacyComponent = exports.LegacyComponent = React.createClass({
function ModernComponent({
initialCount = 0
}) {
var _useState = (0, _react.useState)(initialCount),
_useState2 = (0, _slicedToArray2.default)(_useState, 2),
count = _useState2[0],
setCount = _useState2[1];
var _useState3 = (0, _react.useState)(Status.Active),
_useState4 = (0, _slicedToArray2.default)(_useState3, 2),
status = _useState4[0],
setStatus = _useState4[1];
var [count, setCount] = (0, _react.useState)(initialCount);
var [status, setStatus] = (0, _react.useState)(Status.Active);
(0, _react.useEffect)(() => {
var timer = setInterval(() => {
setCount(c => c + 1);
Expand Down
25 changes: 8 additions & 17 deletions ...abel-preset/src/__tests__/__fixtures__/output/hermes-stable-dev-preserve-block-scoping.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ exports.safeJsonParse = safeJsonParse;
exports.sumPairs = sumPairs;
var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits"));
var _setPrototypeOf2 = _interopRequireDefault(require("@babel/runtime/helpers/setPrototypeOf"));
var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
var _asyncToGenerator2 = _interopRequireDefault(require("@babel/runtime/helpers/asyncToGenerator"));
var _classPrivateFieldLooseBase2 = _interopRequireDefault(require("@babel/runtime/helpers/classPrivateFieldLooseBase"));
var _classPrivateFieldLooseKey2 = _interopRequireDefault(require("@babel/runtime/helpers/classPrivateFieldLooseKey"));
Expand Down Expand Up @@ -153,8 +152,9 @@ function processUser({
age = 18,
...rest
}) {
const _rest$city = rest.city,
city = _rest$city === void 0 ? 'Unknown' : _rest$city;
const {
city = 'Unknown'
} = rest;
return `${name} (${age}) from ${city}`;
}
function mergeConfigs(base, ...overrides) {
Expand All @@ -169,10 +169,7 @@ function mergeConfigs(base, ...overrides) {
function sumPairs(pairs) {
let total = 0;
for (var _iterator = _createForOfIteratorHelperLoose(pairs), _step; !(_step = _iterator()).done;) {
const _ref = _step.value;
var _ref2 = (0, _slicedToArray2.default)(_ref, 2);
const a = _ref2[0];
const b = _ref2[1];
const [a, b] = _step.value;
total += a + b;
}
return total;
Expand Down Expand Up @@ -236,14 +233,8 @@ const LegacyComponent = exports.LegacyComponent = React.createClass({
function ModernComponent({
initialCount = 0
}) {
const _useState = (0, _react.useState)(initialCount),
_useState2 = (0, _slicedToArray2.default)(_useState, 2),
count = _useState2[0],
setCount = _useState2[1];
const _useState3 = (0, _react.useState)(Status.Active),
_useState4 = (0, _slicedToArray2.default)(_useState3, 2),
status = _useState4[0],
setStatus = _useState4[1];
const [count, setCount] = (0, _react.useState)(initialCount);
const [status, setStatus] = (0, _react.useState)(Status.Active);
(0, _react.useEffect)(() => {
const timer = setInterval(() => {
setCount(c => c + 1);
Expand All @@ -261,12 +252,12 @@ function ModernComponent({
return _handleAsyncClick.apply(this, arguments);
}
const handleClick = function () {
var _ref3 = (0, _asyncToGenerator2.default)(function* () {
var _ref = (0, _asyncToGenerator2.default)(function* () {
yield handleAsyncClick();
setStatus(Status.Pending);
});
return function handleClick() {
return _ref3.apply(this, arguments);
return _ref.apply(this, arguments);
};
}();
return (0, _jsxRuntime.jsxs)("div", {
Expand Down
Loading
Loading