Repository navigation
Conversation
Summary: Launching the React Native DevTools shell with Electron's standard `--remote-debugging-port=<port>` switch, for example to drive it from an end-to-end test over the Chrome DevTools Protocol, opens the port but then fails to open any window. Chromium consumes the switch at startup, but the shell's own launch-argument parsing is strict and rejects it as an unknown option, so the window for `--frontendUrl` is never created and the main process logs an unhandled rejection. Here, the launch-argument parser accepts `--remote-debugging-port` and ignores it. Chromium still acts on it, so the shell can be automated the same way as any Electron app, with no shell-specific environment variable or wrapper. Every other unknown option is still rejected. Changelog: [Internal] Differential Revision: D123603419
meta-cla
Bot
added
the
CLA Signed
|
@motiz88 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123603419. |
|
This pull request has been merged in bf62cce. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 13, 2026
Summary: Automated update of React Native DevTools binaries Bundled changes: - **Desktop runtime:** Updated the standalone shell from Electron 39 to 43, including security updates. ([#57422](#57422), [#57338](#57338)) - **App menus:** Added Reload App, Reload DevTools, Quick Open, Command Palette, and Keyboard Shortcuts entries, with icons on macOS 26+. ([#57421](#57421)) - **macOS:** Added the macOS 26/27 app icon. ([#57310](#57310)) - **Automation:** Added support for Electron's `--remote-debugging-port` option. ([#58905](#58905)) - **Maintenance:** Migrated Node.js builtin imports to the `node:` scheme and updated package metadata to the `react` GitHub organization. ([#57611](#57611), [#57258](#57258)) bypass-github-export-checks Changelog: [General][Changed] - **React Native DevTools**: Upgrade the standalone app to Electron 43, add app-menu shortcuts, and add a macOS 26/27 icon Reviewed By: vzaidman Differential Revision: D124263283 fbshipit-source-id: 6b2a3eb729002ee9a11685b73ab5c0d0091600c7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Launching the React Native DevTools shell with Electron's standard
--remote-debugging-port=<port>switch, for example to drive it from an end-to-end test over the Chrome DevTools Protocol, opens the port but then fails to open any window. Chromium consumes the switch at startup, but the shell's own launch-argument parsing is strict and rejects it as an unknown option, so the window for--frontendUrlis never created and the main process logs an unhandled rejection.Here, the launch-argument parser accepts
--remote-debugging-portand ignores it. Chromium still acts on it, so the shell can be automated the same way as any Electron app, with no shell-specific environment variable or wrapper. Every other unknown option is still rejected.Changelog: [Internal]
Differential Revision: D123603419