Repository navigation
Conversation
RCTUITextViewDataDetectorTypesFromStringVector read the mapped value with unsignedIntValue, truncating UIDataDetectorTypeAll (NSUIntegerMax) to 0xffffffff, so UITextView did not treat it as "all". Use unsignedIntegerValue to match the full width of UIDataDetectorTypes, as the legacy RCTConvert path already does (unsignedLongLongValue). Fixes react#55367
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D125664939. |
Collaborator
|
This pull request was successfully merged by @Cedric921 in 0bd2cb1 When will my fix make it into a release? | How to file a pick request? |
|
@cortinico merged this pull request in 0bd2cb1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #55367.
On the New Architecture,
<TextInput dataDetectorTypes="all" />has no effect on iOS, while individual types (link,phoneNumber, …) work.RCTUITextViewDataDetectorTypesFromStringVectorreads the mappedNSNumberwithunsignedIntValue.UIDataDetectorTypeAllisNSUIntegerMax, so it gets truncated to0x00000000ffffffff, which is not equal toUIDataDetectorTypeAlland UIKit does not treat it as "all".This switches to
unsignedIntegerValue, matching the width ofUIDataDetectorTypes(NSUInteger). The legacyRCTConvertpath already reads the same mapping withunsignedLongLongValue, which is why the Old Architecture is unaffected.Changelog:
[IOS] [FIXED] - Fix
TextInputdataDetectorTypes="all"having no effect on the New ArchitectureTest Plan:
I compiled
RCTUITextViewDataDetectorTypesFromStringVector, copied verbatim from the file before and after this change, into a small harness against the iOS SDK (stubbing onlyRCTNSStringFromString), and ran it on an iOS 26 simulator:allnow maps to exactlyUIDataDetectorTypeAll, and the other values are unchanged.I did not run this end-to-end in RNTester. The issue reporter and another user (comment) confirmed that this same patch, applied via patch-package, fixes link detection on 0.81 and 0.86.2.