Skip to content

Cover jsitooling with guards (#58262) #58262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 1 commit into from
Closed

Cover jsitooling with guards (#58262) #58262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-native/ReactCommon/jsitooling/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ target_link_libraries(jsitooling
react_cxxreact
folly_runtime
glog
jsi)
jsi
react_cxxstableapi)

target_compile_reactnative_options(jsitooling PRIVATE)
target_compile_options(jsitooling PRIVATE -Wpedantic)
8 changes: 8 additions & 0 deletions packages/react-native/ReactCommon/jsitooling/React-jsitooling.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ else
source[:tag] = "v#{version}"
end

header_search_paths = []

if ENV['USE_FRAMEWORKS']
header_search_paths << "\"$(PODS_TARGET_SRCROOT)/..\"" # ReactCommon, for <react/cxxstableapi/...>
end

Pod::Spec.new do |s|
s.name = "React-jsitooling"
s.version = version
Expand All @@ -31,12 +37,14 @@ Pod::Spec.new do |s|
resolve_use_frameworks(s, header_mappings_dir: "./", module_name: "JSITooling")

s.pod_target_xcconfig = {
"HEADER_SEARCH_PATHS" => header_search_paths.join(' '),
"CLANG_CXX_LANGUAGE_STANDARD" => rct_cxx_language_standard(),
"DEFINES_MODULE" => "YES",
}

s.dependency "React-cxxreact", version
s.dependency "React-jsi", version
s.dependency "React-cxxstableapi"
add_dependency(s, "React-debug")
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern')
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsitooling/react/runtime/JSRuntimeBindings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <jsi/jsi.h>
#include <string>

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsitooling/react/runtime/JSRuntimeFactory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#ifdef __cplusplus

#include <jsi/jsi.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/jsitooling/react/runtime/JSRuntimeFactoryCAPI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#ifdef __cplusplus
extern "C" {
#endif
Expand Down
Loading