Repository navigation
Inherit text's role and accessibilityRole together (#58022) - #58022
Open
twasilczyk wants to merge 1 commit into
Open
twasilczyk wants to merge 1 commit into
twasilczyk wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@twasilczyk has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116668886. |
twasilczyk
added a commit
to twasilczyk/react-native
that referenced
this pull request
Aug 19, 2026
Summary: Pull Request resolved: react#58022 Inheriting `role` and `accessibilityRole` independently leads to some links inheriting `role=heading` while setting their own `accessibilityRole=link`. This caused the former to overrule the latter, missing link detection. Changelog: [Internal] Differential Revision: D116668886
meta-codesync
Bot
changed the title
twasilczyk
force-pushed
the
export-D116668886
branch
from
August 19, 2026 20:56
27cc6ce to
5142409
Compare
twasilczyk
added a commit
to twasilczyk/react-native
that referenced
this pull request
Oct 14, 2026
Summary: Inheriting `role` and `accessibilityRole` independently leads to some links inheriting `role=heading` while setting their own `accessibilityRole=link`. This caused the former to overrule the latter, missing link detection. Changelog: [Internal] Differential Revision: D116668886
twasilczyk
force-pushed
the
export-D116668886
branch
from
October 14, 2026 13:19
5142409 to
713facd
Compare
Summary: Pull Request resolved: react#58022 Inheriting `role` and `accessibilityRole` independently leads to some links inheriting `role=heading` while setting their own `accessibilityRole=link`. This caused the former to overrule the latter, missing link detection. Changelog: [Internal] Differential Revision: D116668886
twasilczyk
force-pushed
the
export-D116668886
branch
from
October 14, 2026 13:23
713facd to
633b09d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Inheriting
roleandaccessibilityRoleindependently leads to some links inheritingrole=headingwhile setting their ownaccessibilityRole=link. This caused the former to overrule the latter, missing link detection.Changelog: [Internal]
Differential Revision: D116668886