Repository navigation
Better link detection in inline text (#57853) - #57853
Closed
twasilczyk wants to merge 1 commit into
Closed
twasilczyk wants to merge 1 commit into
twasilczyk wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@twasilczyk has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115058930. |
meta-codesync
Bot
changed the title
twasilczyk
force-pushed
the
export-D115058930
branch
from
October 14, 2026 12:42
f4d58da to
b4bfcf6
Compare
Summary: Pull Request resolved: react#57853 Improved link detection to make them appear in Gaze and TalkBack: - Adds support for button RN role in addition to link. These are both triggered by link elements, but the former happens when `<a>` tag is without a `href` - for example `<a href="#" onclick="...">`. - Don't ignore AX role when RN role is set. The latter gets inherited from ancestor, so `axrole=link` under a parent that's `role=header` was not considered a link. Changelog: [Internal] Reviewed By: javache Differential Revision: D115058930
twasilczyk
force-pushed
the
export-D115058930
branch
from
October 14, 2026 12:45
b4bfcf6 to
502abcd
Compare
twasilczyk
added a commit
to twasilczyk/react-native
that referenced
this pull request
Oct 14, 2026
Summary: Improved link detection to make them appear in Gaze and TalkBack: - Adds support for button RN role in addition to link. These are both triggered by link elements, but the former happens when `<a>` tag is without a `href` - for example `<a href="#" onclick="...">`. - Don't ignore AX role when RN role is set. The latter gets inherited from ancestor, so `axrole=link` under a parent that's `role=header` was not considered a link. Changelog: [Internal] Reviewed By: javache Differential Revision: D115058930
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Improved link detection to make them appear in Gaze and TalkBack:
<a>tag is without ahref- for example<a href="#" onclick="...">.axrole=linkunder a parent that'srole=headerwas not considered a link.Changelog: [Internal]
Reviewed By: javache
Differential Revision: D115058930