Skip to content

TextStyleProps verticalAlign vs textAlignVertical #5075

Description

@retyui

Description

I believe we need to add comments to describe difference between these two style props and what should be used verticalAlign or textAlignVertical

What is the problem?

verticalAlign or textAlignVertical it unclear what should be used and can it be combined

example some lib can use one prop but client can use diff prop

import {MyText} from 'my-lib';

<MyText /> // apply `verticalAlign: 'middle'` by default

<MyText style={{ textAlignVertical: 'top' }} />  // <- Can I overload by using diff. style prop (will this even work ?) 

How can we address it?

Add description to show the difference

Why is it important?

give devs better understanding

Who needs this?

Android devs

When should this happen (use version numbers if needed)?

...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions