Repository navigation
Conversation
Our generated `@babel/types` libdef was missing the node definition tables Babel exports (`VISITOR_KEYS`, `NODE_FIELDS`, etc.). This adds them to the generator, typed from the runtime values in Babel 7.29. It also widens `NodePath#key` to `string | number`, since a path inside a list has its numeric index as its key. #2092 currently needs suppressions for both, which we'll remove in a follow-up. Changelog: Internal Test plan: Regenerated with `yarn update-babel-flow-lib-defs` - the only change to the generated file is the new declarations. React Native's copies of both libdefs are identical to ours, and RN's `flow check` is clean with the updated files dropped in.
meta-cla
Bot
added
the
CLA Signed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our generated
@babel/typeslibdef was missing the node definition tables Babel exports (VISITOR_KEYS,NODE_FIELDS, etc.). This adds them to the generator, typed from the runtime values in Babel 7.29.It also widens
NodePath#keytostring | number, since a path inside a list has its numeric index as its key. #2092 currently needs suppressions for both, which we'll remove in a follow-up.Changelog: Internal
Test plan:
Regenerated with
yarn update-babel-flow-lib-defs- the only change to the generated file is the new declarations. React Native's copies of both libdefs are identical to ours, and RN'sflow checkis clean with the updated files dropped in.