Repository navigation
Conversation
|
@nrps9909 is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cellsToDrawin the Canvas fallback used whenPath2Dis unavailableimageSettings.excavatebehavior for older or limited browser environmentsRoot cause
The
Path2Dbranch generated its path fromcellsToDraw, but thefillRectfallback iterated the originalcells. An embedded transparent or semi-transparent image could therefore reveal dark QR modules underneath it wheneverPath2Dwas unavailable.Verification
7de25725d918f352d116abba5ebdece32b79e676fillRectcallsnpm test -- tests/fallback.test.tsx --runInBand— 1/1 passed after the fixnpm test -- --runInBand— 2 suites, 9 tests passednpm run tsc— passednpm run lint— passednpm run compile— ESM, CJS, declarations, and Less build passedgit diff --check— passedAI assistance disclosure: Codex was used to trace the divergent Canvas rendering branches, construct the exact-base regression, implement the one-line fix, and draft this report. I verified the failure count and all listed checks locally.