Skip to content

fix(toolbar): align icon-only buttons - #12

Merged
rdlabo merged 5 commits into
mainfrom
fix/icon-only-toolbar-alignment
Aug 21, 2026
Merged

fix(toolbar): align icon-only buttons#12
rdlabo merged 5 commits into
mainfrom
fix/icon-only-toolbar-alignment

Conversation

@rdlabo

@rdlabo rdlabo commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add toolbar visual-regression cases for clear and solid icon-only buttons in default, small, and large sizes
  • align default icon-only and back-button touch targets with the Material 3 toolbar dimensions while preserving Ionic size and fill behavior
  • keep toolbar icons at 24px and align header start/end and title spacing with slotted toolbar content
  • include the E2E screenshot updates generated by CI

Ref

スクリーンショット 2026-08-21 11 45 46

Checks

  • npm run lint
  • Prettier applied to the four changed source files
  • git diff --check

Closes #6

@rdlabo
rdlabo marked this pull request as ready for review August 21, 2026 01:00
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

passed  78 passed

Details

stats  78 tests across 1 suite
duration  1 minute, 34 seconds
commit  8a4ff21
info  Please check the workflow run for details. And if you want to update the screenshots, please comment with /update-screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Playwright Test Report

View the detailed test report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-12/

github-actions Bot added a commit that referenced this pull request Aug 21, 2026
@rdlabo

rdlabo commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

/update-screenshots

@github-actions

Copy link
Copy Markdown
Contributor

✅ Screenshots have been updated successfully!

The new screenshots have been committed to this PR.

@rdlabo

rdlabo commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

/update-screenshots

@github-actions

Copy link
Copy Markdown
Contributor

📊 Playwright Test Report

View the detailed test report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-12/

@github-actions

Copy link
Copy Markdown
Contributor

✅ Screenshots have been updated successfully!

The new screenshots have been committed to this PR.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Playwright Test Report

View the detailed test report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-12/

github-actions Bot added a commit that referenced this pull request Aug 21, 2026
@rdlabo
rdlabo merged commit 9684735 into main Aug 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon-only toolbar buttons are misaligned

1 participant