Skip to content

feat: support helper and error text for select, checkbox, toggle, and radio group - #125

Merged
rdlabo merged 2 commits into
mainfrom
feat/supporting-text-components
Aug 25, 2026
Merged

feat: support helper and error text for select, checkbox, toggle, and radio group#125
rdlabo merged 2 commits into
mainfrom
feat/supporting-text-components

Conversation

@rdlabo

@rdlabo rdlabo commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add helper and error text demos for checkbox, toggle, select, and radio group
  • integrate select supporting text with inset-list border handling
  • render radio-group supporting text below its items while preserving iOS inset-list radii and safe-area spacing
  • scope radio-group layout customization to structured inset lists

Validation

  • npm run build
  • cd demo && npm test -- --watch=false (35 tests)
  • verified the radio helper/error layouts in the iOS demo browser

@rdlabo rdlabo changed the title feat: support helper and error text components feat: support helper and error text for select, checkbox, toggle, and radio group Aug 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Playwright test results

failed  14 failed
passed  76 passed

Details

stats  90 tests across 2 suites
duration  2 minutes, 45 seconds
commit  81cf096
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

Failed tests

chromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for radio
chromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for toggle
chromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for select:alert
chromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for select:popover
chromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for checkbox
chromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for select:modal
chromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for select:action-sheet
chromium › screenshot.spec.ts › Screenshot Tests - Dark Mode › should match dark mode screenshot for radio
chromium › screenshot.spec.ts › Screenshot Tests - Dark Mode › should match dark mode screenshot for toggle
chromium › screenshot.spec.ts › Screenshot Tests - Dark Mode › should match dark mode screenshot for select:alert
chromium › screenshot.spec.ts › Screenshot Tests - Dark Mode › should match dark mode screenshot for select:popover
chromium › screenshot.spec.ts › Screenshot Tests - Dark Mode › should match dark mode screenshot for checkbox
chromium › screenshot.spec.ts › Screenshot Tests - Dark Mode › should match dark mode screenshot for select:modal
chromium › screenshot.spec.ts › Screenshot Tests - Dark Mode › should match dark mode screenshot for select:action-sheet

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios26/pr-125/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Aug 25, 2026
@rdlabo

rdlabo commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

/update-screenshots

@github-actions

Copy link
Copy Markdown
Contributor

✅ Screenshots have been updated successfully!

The new screenshots have been committed to this PR.

@rdlabo
rdlabo merged commit 17b6a6c into main Aug 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant