Support Angular 21/22 and Ionic 9 - #24
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the plugin’s dependencies and internal TypeScript ESLint imports to support Angular ESLint 21–22, while aligning tests/docs with updated rule reporting patterns.
Changes:
- Expand
@angular-eslint/template-parserpeer dependency range to include v22 and update Angular/TS ESLint/TypeScript dev toolchain versions. - Replace
@typescript-eslint/utils/dist/...deep imports with public@typescript-eslint/utilsimports across multiple rules. - Update rule tests to assert
messageId+data(instead of full message strings) and document the supported Angular ESLint range.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Adds explicit node/jest types to the TS build config. |
| tests/rules/signal-use-as-signal-template-complex.ts | Updates RuleTester expectations to use messageId + data. |
| src/rules/types.ts | Switches TSESTree import to public @typescript-eslint/utils. |
| src/rules/signal-use-as-signal-template.ts | Switches TSESTree import to public @typescript-eslint/utils. |
| src/rules/prefer-disable-handler.ts | Switches TSESTree import to public @typescript-eslint/utils. |
| src/rules/ionic-attr-type-check.ts | Switches TSESTree import to public @typescript-eslint/utils. |
| src/rules/implements-ionic-lifecycle.ts | Consolidates TS ESLint imports and updates ClassElement typing. |
| src/rules/deny-soft-private-modifier.ts | Replaces deep RuleFix import with TSESLint.RuleFix. |
| src/rules/deny-element.ts | Switches TSESTree import to public @typescript-eslint/utils. |
| README.md | Documents Angular ESLint 21–22 support in the Angular/Ionic note. |
| package.json | Updates peer/dev dependency versions for Angular ESLint 22 + TS 6 tooling. |
| package-lock.json | Locks updated dependency graph for the new toolchain versions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| import { TSESLint } from '@typescript-eslint/utils'; | ||
| import { AST_NODE_TYPES } from '@typescript-eslint/types'; | ||
| import { ClassElement } from '@typescript-eslint/types/dist/generated/ast-spec'; | ||
| import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils'; |
…2-compat # Conflicts: # README.md # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Review