RDKEMW-18082: ctrlm coverity cleanup by msmith113 · Pull Request #225 · rdkcentral/control

msmith113 · 2026-05-06T13:22:13Z

https://ccp.sys.comcast.net/browse/RDKEMW-18082

Addresses comments in a previous ctrlm PR:

RDKEMW-14537: Coverity integration for ctrlm #199 (comment) - Remove patch file for devicesetting.h
RDKEMW-14537: Coverity integration for ctrlm #199 (comment) - Remove testframework_overrides.h
RDKEMW-14537: Coverity integration for ctrlm #199 (comment) - Remove xlog_ci_compat.h
RDKEMW-14537: Coverity integration for ctrlm #199 (comment) - Alternative to copying the xr-voice-sdk header files

Related PRs:

Co-authored-by: Copilot <copilot@github.com>

msmith113 · 2026-05-06T14:31:08Z

 # 2. Clone the required repositories

-XRSDK_REF="1.0.13"
+XRSDK_REF="feature/RDKEMW-18082"


Will update once xr-voice-sdk changes are merged

perhaps we can point this to "main" so it always uses the latest release version?

Yes will update this once we merge change for xr-voice-sdk

Copilot

Pull request overview

This PR follows up on prior Coverity/CI integration feedback by removing CI-only shim/patch artifacts and adjusting the native CI dependency/build flow to rely on upstream fixes (via feature branches) rather than local patch layers.

Changes:

Removes CI shims/patch files (xlog_ci_compat.h, testframework_overrides.h, devicesettings_ctrlm.patch) and updates CI build flags accordingly.
Updates ci/build_dependencies.sh to build and install real xr-voice-sdk headers/libs via CMake instead of copying/stubbing.
Adds explicit std:: using-declarations in ctrlm_utils.cpp to replace the removed CI namespace shim behavior.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/ctrlm_utils.cpp	Adds explicit `using std::...` declarations to replace reliance on CI shim behavior.
ci/cov_build.sh	Removes forced inclusion of deleted CI shim/override headers.
ci/build_dependencies.sh	Switches dependency strategy to build/install `xr-voice-sdk` and drops local testframework patching.
ci/mocks/xlog_ci_compat.h	Deleted (CI namespace-compat shim removed).
ci/mocks/testframework_overrides.h	Deleted (CI mock gap overrides removed).
ci/mocks/devicesettings_ctrlm.patch	Deleted (CI-time patch for testframework mocks removed).

msmith113 · 2026-05-07T13:29:28Z

        if(session->packets_processed > 0) {
            uint32_t stream_duration    = session->packets_processed * 20; // assume 20 ms per packet
-            uint32_t samples_per_packet = 320; // 16 kHz samples at 20 ms per packet
+            // uint32_t samples_per_packet = 320; // 16 kHz samples at 20 ms per packet


samples_per_packet is an unused variable, not sure if we want to remove, log it, or something else

dwolaver

looking good

dwolaver · 2026-05-07T19:15:05Z

 # 2. Clone the required repositories

-XRSDK_REF="1.0.13"
+XRSDK_REF="feature/RDKEMW-18082"


perhaps we can point this to "main" so it always uses the latest release version?

dwolaver · 2026-05-07T19:18:10Z

+    -DSTAGING_BINDIR_NATIVE="/usr/bin" \
+    -DCMAKE_PROJECT_VERSION="1.0.13"
+
+# xr-voice-sdk adds -Werror unconditionally, strip it for CI until warnings are dealt with


follow up ticket for this?

Created RDKEMW-18169 for this

rdkcmf-jenkins · 2026-05-08T15:40:20Z

Coverity Issue - Array compared against 0

Comparing an array to null is not useful: ""NEVER" != NULL", since the test will always evaluate as true.

Medium Impact, CWE-398
NO_EFFECT

How to fix

Was ""NEVER"" formerly declared as a pointer?

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/ctrlm_utils.cpp:2337

rdkcmf-jenkins · 2026-05-08T15:40:20Z

Coverity Issue - Array compared against 0

Comparing an array to null is not useful: ""NEVER" != NULL", since the test will always evaluate as true.

Medium Impact, CWE-398
NO_EFFECT

How to fix

Was ""NEVER"" formerly declared as a pointer?

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/ctrlm_utils.cpp:284

rdkcmf-jenkins · 2026-05-08T15:40:20Z

Coverity Issue - Array compared against 0

Comparing an array to null is not useful: ""NEVER" != NULL", since the test will always evaluate as true.

Medium Impact, CWE-398
NO_EFFECT

How to fix

Was ""NEVER"" formerly declared as a pointer?

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/ctrlm_utils.cpp:291

rdkcmf-jenkins · 2026-05-08T15:40:20Z

Coverity Issue - Array compared against 0

Comparing an array to null is not useful: ""NEVER" != NULL", since the test will always evaluate as true.

Medium Impact, CWE-398
NO_EFFECT

How to fix

Was ""NEVER"" formerly declared as a pointer?

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/ctrlm_utils.cpp:298

github-advanced-security · 2026-05-28T15:04:00Z

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

msmith113 and others added 6 commits May 6, 2026 13:21

RDKEMW-18082: ctrlm coverity cleanup

7dfcd39

Testing removing xlog_ci_compat.h

d662739

Co-authored-by: Copilot <copilot@github.com>

Calling cmake on xr-voice-sdk for headers

e1b5beb

Co-authored-by: Copilot <copilot@github.com>

Test

950a494

Co-authored-by: Copilot <copilot@github.com>

Fixing xr-voice-sdk cmake run

68debec

Co-authored-by: Copilot <copilot@github.com>

Another fix

de998e7

Co-authored-by: Copilot <copilot@github.com>

msmith113 commented May 6, 2026

View reviewed changes

Comment thread ci/build_dependencies.sh

msmith113 marked this pull request as ready for review May 6, 2026 14:41

msmith113 requested a review from a team as a code owner May 6, 2026 14:41

Copilot AI review requested due to automatic review settings May 6, 2026 14:41

Copilot started reviewing on behalf of msmith113 May 6, 2026 14:42 View session

Copilot AI reviewed May 6, 2026

View reviewed changes

Comment thread src/ctrlm_utils.cpp

Comment thread ci/build_dependencies.sh Outdated

msmith113 added 2 commits May 6, 2026 14:49

Addressing copilot comment about missing includes

33b07b6

Removing unused var

755f661

Copilot AI review requested due to automatic review settings May 6, 2026 15:51

Copilot started reviewing on behalf of msmith113 May 6, 2026 15:52 View session

msmith113 commented May 7, 2026

View reviewed changes

msmith113 added 4 commits May 7, 2026 13:35

Update

f28a94d

Removing sefec mock

03c2ff8

Fix

bce2fb3

Updates

eca9dde

dwolaver reviewed May 7, 2026

View reviewed changes

msmith113 added 5 commits May 8, 2026 13:55

Test

2baae1d

Update

4bd79b1

Test

0593333

Fix

b61a90d

Update

995c93b

msmith113 added 11 commits May 8, 2026 16:41

Update to prevent warning from copied safec header

a0595cb

Test

a55c533

Test

37bf0e9

Testing

6bb6049

Update

72bf7ca

Test

f506840

Updates

95695a2

Update

93041b5

Test

2255d47

Fix

1f6d6a2

Update

830304a

Test

dd517be

Conversation

msmith113 commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msmith113 May 6, 2026

Choose a reason for hiding this comment

Uh oh!

dwolaver May 7, 2026

Choose a reason for hiding this comment

Uh oh!

msmith113 May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

msmith113 May 7, 2026

Choose a reason for hiding this comment

Uh oh!

dwolaver left a comment

Choose a reason for hiding this comment

Uh oh!

dwolaver May 7, 2026

Choose a reason for hiding this comment

Uh oh!

dwolaver May 7, 2026

Choose a reason for hiding this comment

Uh oh!

msmith113 May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 8, 2026

Coverity Issue - Array compared against 0

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented May 8, 2026

Coverity Issue - Array compared against 0

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Array compared against 0

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Array compared against 0

How to fix

Issue location

Uh oh!

github-advanced-security AI commented May 28, 2026

What Enabling Code Scanning Means:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

msmith113 commented May 6, 2026 •

edited

Loading

rdkcmf-jenkins commented May 8, 2026 •

edited

Loading

rdkcmf-jenkins commented May 8, 2026 •

edited

Loading