Add Options to Control Table of Files and Change Default Display#60
Merged
Conversation
…ary. Added two options to show individual and all files in results. Option `--show-files` and option `--show-all-files` for scount. Modified output functions to conditionally display file tables based on new options. Added tests for new functionality to ensure correct output. Changed existing functionality tests to include the '--show-files' option when invoking scount under test so that the expected output stays the same and the test assertion is not invalidated by this change. [CL]: Added scount CLI --show-files option to control file table display in output. [CL]: Added scount CLI --show-all-files option to control file table display in output. [CL]: Changed scount output behaviour to not show file table by default. Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
Added documentation for --show-files and --show-all-files options. Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
Changed options indication to be shorter. Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
Test case for --show-files should be different than --show-all-files. Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the default output of
scountto not show file table by default, only the summary table.Adds two options to show individual and all files in results.
Option
--show-filesresults in the old behaviour. It will show results for individual files, but only to a certain limit.Option
--show-all-filessimply shows the result table for all files, not matter how many there are.Changes existing functionality tests to include the
--show-filesoption when invokingscountunder test so that the expected output stays the same and the test assertion is not invalidated by this change.