Skip to content

Add "ignore failures until" mechanism to check-nightly-success - #158

Merged
rapids-bot[bot] merged 9 commits into
mainfrom
temp-extension
Nov 2, 2026
Merged

rapids-bot[bot] merged 9 commits into
mainfrom
temp-extension

Conversation

@KyleFromNVIDIA

@KyleFromNVIDIA KyleFromNVIDIA commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

If a project goes for an extended period of time without a successful nightly run, they sometimes temporarily increase their maximum days without success. Rather than doing that, provide a mechanism to ignore failures until a specific day, so that the max days without success never needs to be updated, and the temporary measure stays temporary, even if the until-date is never removed.

This mechanism supersedes all other checks if it passes, meaning if the current date is less than the until-date, GitHub is never checked for successful workflows.

If a project goes for an extended period of time without a successful
nightly run, they sometimes temporarily increase their maximum days
without success. Rather than doing that, provide a temporary extension
mechanism that expires on a specific day, so that the max days without
success never needs to be updated, and the temporary measure stays
temporary, even if the extension date is never removed.

This mechanism supersedes all other checks if it passes, meaning if the
current date is less than the temporary expiration, GitHub is never
checked for successful workflows.
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 23, 2026
@KyleFromNVIDIA
KyleFromNVIDIA requested a review from a team as a code owner October 23, 2026 13:16
@KyleFromNVIDIA
KyleFromNVIDIA requested a review from bdice October 23, 2026 13:16
@KyleFromNVIDIA

KyleFromNVIDIA commented Oct 23, 2026 •

Copy link
Copy Markdown
Member Author

Another idea: if the workflow is found to not have any passes in the last X days, but it had a pass in the last X days before the temporary extension, then it must pass again, even if it's before the extension date, ensuring that once it passes, it has to keep passing. Never mind, that wouldn't work.

Oh! Instead, we could have a "temp extension start" and "temp extension end", and if there were any passing runs between those two times, then the temp extension is void unless it gets renewed with a new start date.

@KyleFromNVIDIA

KyleFromNVIDIA commented Oct 23, 2026 •

Copy link
Copy Markdown
Member Author

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the concept, implementation looks good, and I appreciate the testing!

I left one comment... I think the naming would be confusing to anyone who doesn't already have context about the use of this action and the history that led to this PR. Started a thread about that.

Marking this "approve" so you can move forward with it with whatever you decide, I don't want to hold it up for bikeshedding on the name.

@KyleFromNVIDIA KyleFromNVIDIA changed the title Add temporary extension mechanism to check-nightly-success Add "ignore failures until" mechanism to check-nightly-success Nov 2, 2026
@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 3b46f25 into main Nov 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants