Repository navigation
Add "ignore failures until" mechanism to check-nightly-success - #158
Conversation
If a project goes for an extended period of time without a successful nightly run, they sometimes temporarily increase their maximum days without success. Rather than doing that, provide a temporary extension mechanism that expires on a specific day, so that the max days without success never needs to be updated, and the temporary measure stays temporary, even if the extension date is never removed. This mechanism supersedes all other checks if it passes, meaning if the current date is less than the temporary expiration, GitHub is never checked for successful workflows.
|
Oh! Instead, we could have a "temp extension start" and "temp extension end", and if there were any passing runs between those two times, then the temp extension is void unless it gets renewed with a new start date. |
This reverts commit b5ca56c.
|
Temporary extension in action: https://github.com/NVIDIA/cudf/actions/runs/39962717089/job/120445673667?pr=24804#step:3:174 |
jameslamb
left a comment
There was a problem hiding this comment.
I like the concept, implementation looks good, and I appreciate the testing!
I left one comment... I think the naming would be confusing to anyone who doesn't already have context about the use of this action and the history that led to this PR. Started a thread about that.
Marking this "approve" so you can move forward with it with whatever you decide, I don't want to hold it up for bikeshedding on the name.
check-nightly-successcheck-nightly-success
|
With new naming convention... No until-date: https://github.com/NVIDIA/cudf/actions/runs/41486388951/job/125417743633#step:3:172 |
|
/merge |
If a project goes for an extended period of time without a successful nightly run, they sometimes temporarily increase their maximum days without success. Rather than doing that, provide a mechanism to ignore failures until a specific day, so that the max days without success never needs to be updated, and the temporary measure stays temporary, even if the until-date is never removed.
This mechanism supersedes all other checks if it passes, meaning if the current date is less than the until-date, GitHub is never checked for successful workflows.