Skip to content

Add yamllint check - #167

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
KyleFromNVIDIA:yamllint
Oct 8, 2026
Merged

rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
KyleFromNVIDIA:yamllint

Conversation

@KyleFromNVIDIA

Copy link
Copy Markdown
Member

And bump pre-commit-hooks to 1.7.0.

And bump pre-commit-hooks to 1.7.0.
@KyleFromNVIDIA
KyleFromNVIDIA requested review from a team as code owners October 8, 2026 19:43
@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

@jameslamb I think you'll be particularly interested in this one 😁

@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: rapidsai/pre-commit-hooks/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 3552b2de-dc39-416c-b160-5c85c457e1fe
📥 Commits

Reviewing files that changed from the base of the PR and between 21e21d0 and a6b8373.

📒 Files selected for processing (2)
  • .pre-commit-config.yaml
  • .yamllint.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Added automated checks for YAML formatting and common issues, including duplicate keys, spacing, and permitted boolean values.
    • Copyright verification now also covers the YAML lint configuration file.
    • Updated the pre-commit checks to a newer revision.

Walkthrough

The pre-commit configuration updates the RAPIDS hook revision, includes .yamllint.yaml in copyright verification, and adds yamllint. A new .yamllint.yaml file configures yamllint rules.

Changes

YAML lint integration

Layer / File(s) Summary
Configure YAML linting
.pre-commit-config.yaml, .yamllint.yaml
The pre-commit configuration updates the RAPIDS hook revision, extends the copyright hook pattern to include .yamllint.yaml, and adds the yamllint hook at v1.38.0. The new .yamllint.yaml configuration extends default and sets lint rules.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to a6b83

The change adds YAML linting without evidence of a failure in the repository’s current checks. It appears ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description accurately identifies both changes: adding the yamllint check and updating pre-commit-hooks to version 1.7.0.
Title check ✅ Passed The title clearly and concisely describes the main change, which is adding the yamllint check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, love this! Thanks for doing it.

@jameslamb
jameslamb removed the request for review from msarahan October 8, 2026 20:57
@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 6863f45 into rapidsai:main Oct 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants