Skip to content

Remove remaining references to bashlex - #164

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
KyleFromNVIDIA:remove-bashlex
Oct 7, 2026
Merged

rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
KyleFromNVIDIA:remove-bashlex

Conversation

@KyleFromNVIDIA

Copy link
Copy Markdown
Member

Follow-up to #163.

@KyleFromNVIDIA
KyleFromNVIDIA requested review from a team as code owners October 7, 2026 18:50
@KyleFromNVIDIA
KyleFromNVIDIA requested a review from bdice October 7, 2026 18:50
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: rapidsai/pre-commit-hooks/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 390a5d6f-c642-4259-8de2-914d42e34860
📥 Commits

Reviewing files that changed from the base of the PR and between 9c25cca and dccd0ce.

📒 Files selected for processing (3)
  • .pre-commit-config.yaml
  • README.md
  • pyproject.toml
💤 Files with no reviewable changes (3)
  • README.md
  • .pre-commit-config.yaml
  • pyproject.toml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Removed Bashlex from the project’s runtime dependencies and development tooling configuration.
    • Removed the Bashlex acknowledgment and related links from the README.
    • These changes do not describe any changes to user-facing features or behavior.

Walkthrough

The project no longer lists Bashlex as a runtime or mypy hook dependency. The mypy missing-import override and the README acknowledgement for Bashlex were also removed.

Changes

Bashlex dependency and reference removal

Layer / File(s) Summary
Remove Bashlex dependency and references
.pre-commit-config.yaml, pyproject.toml, README.md
Removed Bashlex from runtime and mypy hook dependencies, removed the bashlex.* missing-import override, and removed the README acknowledgement.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: bdice

Merge Risk: ⚪ Minimal · up to dccd0

No remaining project use of Bashlex was found, so its removal presents no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description identifies this pull request as a follow-up to PR #163. This is related to the changes that remove remaining bashlex references.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the remaining bashlex references.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

/merge

@jameslamb
jameslamb removed the request for review from bdice October 7, 2026 19:07
@rapids-bot
rapids-bot Bot merged commit 3c20650 into rapidsai:main Oct 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants