fix(quest): bundle portable publication safety checks - #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forge-review publisher depended on a repository maintenance script outside the quest skill. Move the existing scanner into the skill and resolve it beside the publisher; keep the repository gate as a thin wrapper over that same implementation.
Remove maintainer-specific domain patterns, add case-insensitive Windows profile-path detection, and check scanner dependencies before composing a publication. Missing tools now name an installation/PATH remedy. Unsafe content and scanner faults stop publication with distinct messages that do not echo private content.
The scanner remains deterministic executable code because publication must stop on an unsafe body or an incomplete scan. This relocates the existing implementation rather than adding a second scanner. The repository wrapper preserves its default checkout scope. Plugin version: 4.7.1.
Validation:
just verifysuccessfully on commit 5095a43: 214 record assertions and 26 test suites passed, plus lint, formatting, safety, packaging, version declaration, and workflow gates.Requested as one change for #338 and #339. Attunement-wide tool validation is tracked separately in #340.
Closes #338
Closes #339