Repository navigation
Conversation
json 3 removed the quirks_mode option, which Active Support 7.1 and 8.0 still pass to JSON.generate. CI's `bundle update railties` picks json 3, so serializing job arguments raises ArgumentError, the processes started by integration tests die and those jobs hang until the 15-minute timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rails_7_1andrails_8_0CI jobs are timing out after 15 minutes on every PR (e.g. https://github.com/rails/solid_queue/actions/runs/37324247004).CI's
bundle update railtiesnow picks json 3.0.2, which removed thequirks_modeoption that Active Support 7.1 and 8.0 still pass toJSON.generate. Serializing job arguments raisesArgumentError: unknown keyword: quirks_mode, the processes started by integration tests die, and the tests wait until the job is cancelled. Rails 7.2+ isn't affected.This pins
json < 3for those two appraisals. Checked locally with Active Support 7.1.6 and 8.0.5.1:ActiveSupport::JSON.encoderaises with json 3.0.2 and works with 2.21.2, which is what the pinned Gemfiles resolve to.