test(e2e): deterministic H3 t2va 2-GPU flowGRPO metric to prevent regression - #217
Merged
Conversation
Rockdu
force-pushed
the
h3-2gpu-e2e
branch
3 times, most recently
from
August 29, 2026 14:25
e0ca7c9 to
0341b56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--deterministic-modeon the H3 t2va 2-GPU flowGRPO recipe, matching the SD3 recipes that back a metric-regression e2e.tests/e2e/short/test_h3_t2va_grpo_2xGPU.py(stage-c-3-gpu-h200, 2 rollouts) with its recorded standard, so H3 gets the same bit-for-bit metric regression the other families already have.CI sizing: the test runs the recipe at
--n-samples-per-prompt 4 --eval-interval 0(8 videos per rollout, no eval). The recipe's own sizes put one tp2 engine at ~60 min for two rollouts, past the suite's timeout; this config keeps both rollouts — so the LoRA-IPC weight sync between them stays covered — at 1492 s in CI.Why
H3 is the family with the most model-specific rollout code (its own packed-sequence denoise loop, its own SDE update, its own LoRA-IPC weight key mapper), and no e2e guarded it — regressions there only surfaced on the 17/34-GPU production runs.
Validation
Recorded on H200 against
mainbefore #215/#216, with stocksglang-miles-h3,--deterministic-mode, 2 rollouts:rollout/reward/raw_meanrollout/reward/raw_stdtrain/log_prob_mean_abs_difflog_prob_mean_abs_difflands in the e-5 band the H3 recipe is verified against, i.e. the train forward reproduces the rollout trajectory; reward moves in the expected direction across the two rollouts.The same recipe was also recorded on top of #216 (SDE-window trajectory transport) with its sglang counterpart: all eight metric series came out bitwise identical to this baseline, which is the H3-path evidence that the windowed transport changes nothing observable. CI on this test then passed against the standard, so the run is reproducible across machines, not just locally.
Files
scripts/run_diffusion_grpo_h3_t2va_2gpu.py—--deterministic-mode.tests/e2e/short/test_h3_t2va_grpo_2xGPU.py+tests/ci/fixtures/e2e_standards/test_h3_t2va_grpo_2xGPU.json— the test and its standard.Checklist
pre-commit run --all-filespassespytest -xis green — tests/fast, 239 passedpython3 train_diffusion.py --helpstill parses — no new flags