[model] fix: handle separate KV normalization in GLM TileLang attention - #37
Open
yushengsu-thu wants to merge 3 commits into
Open
[model] fix: handle separate KV normalization in GLM TileLang attention#37yushengsu-thu wants to merge 3 commits into
yushengsu-thu wants to merge 3 commits into
Conversation
Signed-off-by: Yusheng Su <yushengsu.thu@gmail.com>
This was referenced Sep 10, 2026
Signed-off-by: Yusheng Su <yushengsu.thu@gmail.com>
Signed-off-by: Yusheng Su <yushengsu.thu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer GLM DSA specs normalize the KV latent in a separate module. The TileLang absorb path previously assumed a fused projection layernorm, accessing an absent attribute and attempting to normalize the latent again. Read the fused layernorm weight only when present, applying KV RMSNorm exactly once while retaining the existing differentiable LoRA weight folding.
Validation on
3dabfd2ae840cbb7e9080d3b4e398c0e5eb7843b:Companions: Miles #3174, SGLang #38760.
The v10 cross-node retry used SGLang
f6f03206a74bce5910d04f3581a423a68beb25d5, which fixes a reproduced peer-local port precheck false positive. Its11 PortArgs tests and changed-file pre-commit pass; full GPU evidence above remains scoped to the preceding SGLang head.V10 was externally stopped through the Ray stop API at2026-09-10 06:12:46UTC, after selecting12/16 samples and before its first optimizer step. The reward guard did not trigger and no preceding training failure was observed; the stop caller is unidentified. No job is currently running. Host-memory peaks during startup/sampling were873.23GiB and870.13GiB, but the post-training offload peak and consecutive publication cycles remain unverified.