Improve line-number accuracy in radius-code-review skill#12017
Open
brooke-hamilton wants to merge 1 commit into
Open
Improve line-number accuracy in radius-code-review skill#12017brooke-hamilton wants to merge 1 commit into
brooke-hamilton wants to merge 1 commit into
Conversation
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Radius code-review skill to reduce incorrect inline-review line numbers by requiring anchor snippets, verification, and runtime line resolution.
Changes:
- Adds anchor-based review comment formatting and mandatory line-number accuracy guidance.
- Adds a verification step to compare cited lines against anchors before script generation.
- Updates the generated review-posting script template to resolve line numbers from anchors.
| # from silently landing a comment on the wrong line. | ||
| line_for() { | ||
| local file="$1" anchor="$2" matches | ||
| matches=$(grep -nF -- "${anchor}" "${file}" || true) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the
radius-code-reviewskill to eliminate incorrect line numbers, which is a frequent issue with the review scripts. An alternate approach is to remove the generated script altogether.Changes
.github/skills/radius-code-review/SKILL.md:grep -n, and to ensure the cited line is on theRIGHTside of the diff.line_forshell helper that resolves line numbers from anchors at script build time and fails loudly if an anchor matches zero or more than one line, so a wrong/stale anchor aborts the script instead of mis-placing a comment.Type of change