Repository navigation
Conversation
Member
|
It's been a while since I thought about this, so would you mind walking me through the logic here? |
Contributor
Author
|
This keeps the cached response's status after a 304 revalidation. Before, the first request returned 200, but from the first revalidation onwards every request returned 304. This follows RFC 9110 §15.4.5: a 304 means the stored copy should be used "as if it were the content of a 200 (OK) response". But the wording isn't quite clear on the status code, so I think it can go either one and this can be closed. most libs seem to be following it as far as I can tell: OkHttp, requests-cache and Go's httpcache |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.