Repository navigation
Report the right count when req_perform_sequential() is interrupted - #893
Merged
Merged
Conversation
m-muecke
force-pushed
the
fix/sequential-interrupt-count
branch
from
October 7, 2026 08:26
ee34aa7 to
aef991b
Compare
hadley
reviewed
Oct 7, 2026
| check_repeated_interrupt() | ||
|
|
||
| resps <- resps[seq_len(i)] | ||
| # interrupt might occur before request i completes |
Member
There was a problem hiding this comment.
We don't need to truncate resps still?
Contributor
Author
There was a problem hiding this comment.
this never had any effect, since it ran in the tryCatch handler and the local copy was never used
Contributor
Author
There was a problem hiding this comment.
ah resps <<- resps[seq_len(i)] was likely the intent
Contributor
Author
There was a problem hiding this comment.
that makes more sense, that would follow req_perform_iterative() and truncate as well
Member
There was a problem hiding this comment.
Ah yeah, that sounds like the goal.
Member
|
Would you mind having a stab at writing a test for this? It's totally possible that it won't be worth it and then I'll ask you to delete it 😄, but I'd like to see what claude/chatgpt suggests. |
Contributor
Author
|
no problem, done |
Member
|
That wasn't bad at all 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matchs
req_perform_iterative()