Repository navigation
Conversation
Add the missing Qt Designer template for the Coder Comparisons dialog (it was the only dialog without a .ui source in src/GUI_UIs) and regenerate the .py file with pyuic6, so future .ui edits no longer conflict with hand-edited generated code. Following review feedback: - replace the 'Select files' text button with a 32x32 icon button (mdi6.file-document-multiple-outline, set in reports.py like the other icon buttons) - add a label next to it showing 'Files: All' or 'Files: N' (number of selected files) Co-authored-by: qwertygc <qwertygc@users.noreply.github.com>
The .ui template only carries an empty 32x32 button; icons are set in code via qtawesome like every other icon button in the project. Co-authored-by: qwertygc <qwertygc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/GUI_UIs/ui_report_comparisons.uifor the Coder Comparisons dialog (the only dialog without a .ui source) and regenerateui_report_comparisons.pywith pyuic6, so future .ui edits will not conflict with hand-edited generated codelabel_fileslabel next to the button showing "Files: All" or "Files: N" (number of selected files)Notes for the reviewer
reports.pyviaqta.icon(...), like every other icon button in the project (the .ui only carries an empty 32x32 button)__main__blockVerification
pyuic6regeneration diffed against the previous .py: only canonical widget reordering, no functional changepython -m py_compileon the regenerated file