Skip to content

Coder comparisons dialog: add .ui template, icon button and Files label - #16

Draft
qwertygc wants to merge 2 commits into
masterfrom
vibe/comparisons-icon-label-b8791c
Draft

qwertygc wants to merge 2 commits into
masterfrom
vibe/comparisons-icon-label-b8791c

Conversation

@qwertygc

Copy link
Copy Markdown
Owner

Summary

  • Add the missing Qt Designer template src/GUI_UIs/ui_report_comparisons.ui for the Coder Comparisons dialog (the only dialog without a .ui source) and regenerate ui_report_comparisons.py with pyuic6, so future .ui edits will not conflict with hand-edited generated code
  • Replace the "Select files" text button with a 32x32 icon button (mdi6.file-document-multiple-outline), consistent with the other icon buttons in the dialog
  • Add a label_files label next to the button showing "Files: All" or "Files: N" (number of selected files)

Notes for the reviewer

  • The icon is set in reports.py via qta.icon(...), like every other icon button in the project (the .ui only carries an empty 32x32 button)
  • The label text is updated by the subcorpus selection logic in the companion PR Kappa on subcorpus: file selection in coder comparisons + n/a for non-computable stats #15
  • The .py file was regenerated with pyuic6 6.11.0; the only differences with master are the widget reordering (canonical Designer order), the new button/label and the removal of the hand-added __main__ block

Verification

  • pyuic6 regeneration diffed against the previous .py: only canonical widget reordering, no functional change
  • python -m py_compile on the regenerated file

mistral-vibe and others added 2 commits October 13, 2026 06:22
Add the missing Qt Designer template for the Coder Comparisons dialog
(it was the only dialog without a .ui source in src/GUI_UIs) and
regenerate the .py file with pyuic6, so future .ui edits no longer
conflict with hand-edited generated code.

Following review feedback:
- replace the 'Select files' text button with a 32x32 icon button
  (mdi6.file-document-multiple-outline, set in reports.py like the
  other icon buttons)
- add a label next to it showing 'Files: All' or 'Files: N' (number of
  selected files)

Co-authored-by: qwertygc <qwertygc@users.noreply.github.com>
The .ui template only carries an empty 32x32 button; icons are set in
code via qtawesome like every other icon button in the project.

Co-authored-by: qwertygc <qwertygc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants