Use CRC32C for checksums instead of MD5#6442
Open
nadav-govari wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Spans show that MD5 computations can take on the order of seconds, and were being computed on the non-blocking threads. Luckily we were only doing multipart uploads on massive splits so the vast majority of our uploads were unaffected.
MD5 isn't recommended anymore anyway, and on modern architecture, CRC32C has hardware acceleration. (Theres a software fallback if the architecture doesnt support it: https://docs.rs/crc32c/latest/crc32c/)
How was this PR tested?
Local deployment uploads succeed.