wayland/background-effect: attach effect surface when manager global appears late - #909
Open
bbedward wants to merge 1 commit into
Open
wayland/background-effect: attach effect surface when manager global appears late#909bbedward wants to merge 1 commit into
bbedward wants to merge 1 commit into
Conversation
bbedward
force-pushed
the
ext-bg-effect-active-changed
branch
from
July 21, 2026 13:29
815ba8f to
7184c08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the compositor announces ext_background_effect_manager_v1 after a surface is created, ext-background-effect will not apply to the surface. I'm not sure if this is a
With niri at least, this happens at compositor startup in some cases (AvengeMedia/DankMaterialShell#2856), I'm not sure if this is a bug on niri's side as I haven't looked at that side much but in either case it makes sense to react to it if the protocol becomes available lazily.
This adds listener to activeChanged to attach the effect to the surface when it becomes active.