Test amalgamated build on Windows#969
Draft
saghul wants to merge 1 commit into
Draft
Conversation
saghul
marked this pull request as draft
March 11, 2025 20:03
saghul
force-pushed
the
win-test-amalgam
branch
from
March 11, 2025 20:20
e413c51 to
c1afb7a
Compare
Contributor
Author
|
Fun! |
Contributor
Author
|
@bnoordhuis Do you happen to know if The Redmond Compiler chokes on preprocessor marcos names like reserved words in C files, but not in header files?! |
Contributor
|
Not to my knowledge but that's not quite the same thing as 'no'. :-) I built commit fd5f6f3 locally and ran amalgam.js but the line numbers from CI don't match up with the generated quickjs-amalgam.c. Do you see the same thing? |
Contributor
Author
|
I'll give it a nother try after you merge that and I rebase. I'll also try it on MinGW to double check... |
saghul
force-pushed
the
win-test-amalgam
branch
from
March 23, 2025 19:52
fd5f6f3 to
f9f72a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.