[QEff. Finetuning] TP+DDP for transformers upgrade to v5.5.4 #960
Open
smedhe wants to merge 35 commits intoquic:ft_experimental_v1from
Open
[QEff. Finetuning] TP+DDP for transformers upgrade to v5.5.4 #960smedhe wants to merge 35 commits intoquic:ft_experimental_v1from
smedhe wants to merge 35 commits intoquic:ft_experimental_v1from
Conversation
…T parity
- Rebased downstream wrapper stack to transformers==5.3.0 and aligned coupled deps
(huggingface-hub, peft, diffusers) in project config.
- Updated model wrapper compatibility paths across causal/VLM/audio/export flows
to match upstream v5 APIs while preserving downstream public behavior.
- Hardened cache compatibility layer and runtime glue for mixed legacy/new cache
semantics used by downstream generation/export paths.
- Fixed attention/mask/rotary call-path mismatches introduced by upstream API
changes (including model-specific signature updates).
- Updated AWQ/quantizer and export compatibility paths to remain ONNX-safe.
- Resolved MoE/export edge cases (including Mixtral/gpt_oss) to keep
HF PyTorch -> downstream PyTorch -> ONNXRuntime token parity.
- Validation evidence:
pyenv activate qeff.mainline
python -m pytest -q tests/test_model_quickcheck.py -n 16
Result: 26 passed.
Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
…odeling_qeff Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Adding TF 5.5 support
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: asmigosw <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
quic-akuruvil
requested changes
May 6, 2026
Contributor
quic-akuruvil
left a comment
quic-akuruvil
left a comment
There was a problem hiding this comment.
There are so many redundant file changes. Take transforemrs V5.5.4 upgrade branch from models' team, and then raise a PR, keeping that as the base branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds TP + DDP support and updates the codebase to remain compatible with newer versions of the dependent libraries. The changes have been validated against the following library versions:
transformers 5.5.4
peft 0.19.1
trl 1.2.0
accelerate 1.13.0