feat(ui): 사이드바 공간을 줄이기 위해 언어 선택을 접습니다#1019
Merged
Merged
Conversation
오른쪽 TOC 영역에서 세 언어 버튼을 항상 노출하지 않고 dropdown Trigger/Menu Panel로 전환합니다. Constraint: 오른쪽 사이드바의 기존 locale cookie와 URL 전환을 유지해야 합니다 Rejected: Nextra 기본 i18n selector로 이동 | 오른쪽 사이드바 노출 요구와 맞지 않습니다 Confidence: high Scope-risk: narrow Directive: 언어 추가 시 languages 배열과 dropdown 테스트를 함께 갱신합니다 Tested: npm run test:run -- src/components/language-selector2.test.tsx 'src/app/[lang]/layout.test.ts' Tested: npm run lint -- src/components/language-selector2.tsx src/components/language-selector2.test.tsx Tested: npx prettier --check src/components/language-selector2.tsx src/components/language-selector2.test.tsx Tested: git diff --check Not-tested: 브라우저 visual smoke는 local dev server 미요청 지침에 따라 생략했습니다 Generated-with: Codex Co-Authored-By: Atlas <atlas@jk.agent>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
오른쪽 사이드바의 언어 선택 영역이 차지하는 공간을 줄이기 위해 버튼 목록을 dropdown menu로 전환합니다.
NEXT_LOCALE쿠키 저장과 locale path 전환 동작을 유지합니다.aria-checked표시를 추가합니다.Test plan
npm run test:run -- src/components/language-selector2.test.tsx 'src/app/[lang]/layout.test.ts'npm run lint -- src/components/language-selector2.tsx src/components/language-selector2.test.tsxnpx prettier --check src/components/language-selector2.tsx src/components/language-selector2.test.tsxgit diff --checkRelated tickets & links
🤖 Generated with Codex