fix: Spotlight를 internal 페이지로 한정합니다#1018
Merged
Merged
Conversation
## Summary
전역 Nextra layout에 들어간 Spotlight 주입을 제거하여 일반 문서 페이지에는 회사 소식 카드가 보이지 않도록 합니다.
- root layout의 TOC extraContent를 ConfluenceSourceLink 전용으로 되돌립니다.
- Spotlight는 /{locale}/internal 페이지의 전용 렌더만 유지합니다.
- root layout에 Spotlight가 다시 들어오지 않도록 회귀 테스트를 추가합니다.
Constraint: PR #1017이 이미 main에 병합되어 새 fix PR로 수정해야 했습니다.
Rejected: main 직접 push | 명시적 승인 없이 main에 직접 push하지 않는 저장소 규칙을 위반합니다.
Confidence: high
Scope-risk: narrow
Directive: /{locale}/internal 외 경로에는 DocsSpotlightSidebar를 전역 layout으로 주입하지 않습니다.
Tested: npm run test:run -- src/app/[lang]/layout.test.ts src/app/[lang]/internal/page.test.tsx src/components/docs-spotlight-card.test.tsx src/lib/docs-spotlight/content.test.ts
Tested: npm run lint
Tested: npx tsc --noEmit
Tested: git diff --check
Tested: headless Chrome에서 /ko/internal은 Spotlight 표시, /ko/overview는 Spotlight 미표시를 확인했습니다.
Not-tested: production build는 로컬 기본 검증 범위에서 제외했습니다.
Generated-With: Codex
Co-Authored-By: Atlas <atlas@jk.agent>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #1017 병합 후 Spotlight가 전체 문서 페이지 TOC에 노출되는 문제를 수정합니다.
DocsSpotlightSidebar주입을 제거합니다./{locale}/internal페이지 전용 렌더만 유지합니다.Test plan
npm run test:run -- src/app/[lang]/layout.test.ts src/app/[lang]/internal/page.test.tsx src/components/docs-spotlight-card.test.tsx src/lib/docs-spotlight/content.test.tsnpm run lintnpx tsc --noEmitgit diff --check/ko/internal은 Spotlight 표시,/ko/overview는 Spotlight 미표시를 확인했습니다.Related tickets & links
Additional notes
LanguageSelector2의 잘못된<p>중첩 hydration 경고가 dev 로그에 보였지만, 이번 Spotlight 전역 노출 문제와는 별개입니다.🤖 Generated with Codex