feat: 내부 테스트 페이지 route 추가#1015
Merged
Merged
Conversation
Constraint: The user requested an App Router page.tsx rather than MDX content, with only a title and description visible for now.
Rejected: MDX content page | It would route through the documentation content pipeline instead of an independent app route.
Confidence: high
Scope-risk: narrow
Directive: Keep /{locale}/internal as a sparse internal landing surface until concrete test pages are intentionally added.
Tested: npm run test:run -- 'src/app/[lang]/internal/page.test.tsx'; npm run lint -- 'src/app/[lang]/internal/page.tsx' 'src/app/[lang]/internal/page.test.tsx'; npx tsc --noEmit; git diff --check
Not-tested: Browser rendering against a deployed preview URL is pending PR deployment.
Co-Authored-By: Atlas <atlas@jk.agent>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Constraint: Next/Nextra static generation invoked the new internal route metadata with missing params. Rejected: Disabling metadata generation | The route still needs localized metadata and a safe fallback. Confidence: high Scope-risk: narrow Directive: Keep App Router metadata functions tolerant of omitted params when they can be called by static generation. Tested: npm run test:run -- 'src/app/[lang]/internal/page.test.tsx'; npm run lint -- 'src/app/[lang]/internal/page.tsx' 'src/app/[lang]/internal/page.test.tsx'; npx tsc --noEmit; npm run build; git diff --check Not-tested: Preview deployment rerun result pending after push. Co-Authored-By: Atlas <atlas@jk.agent>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
기존 문제
/{locale}/internal경로에 기능 테스트와 구현 참고를 위한 내부 페이지 진입점이 없었습니다.구현 내용
src/app/[lang]/internal/page.tsx를 추가해 App Router 기반 독립 페이지를 구성했습니다.ko,en,jalocale별 최소 copy와 route metadata를 제공합니다.params없이 호출되는 경우에도 안전하게 fallback하도록 보강했습니다.CI/배포 오류 대응
generateMetadata가params없이 호출되어langdestructuring 오류로npm run build가 실패했습니다.params를 optional로 처리하고 누락 시encopy로 fallback하도록 변경했습니다./{locale}/internal출력은 유지하면서, CI build와 Preview Deploy가 같은 오류로 중단되지 않도록 했습니다.검증
npm run test:run -- 'src/app/[lang]/internal/page.test.tsx'npm run lint -- 'src/app/[lang]/internal/page.tsx' 'src/app/[lang]/internal/page.test.tsx'npx tsc --noEmitnpm run buildgit diff --check참고
Refs #1004