Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions news/changelog-1.11.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All changes included in 1.11:

- ([#14741](https://github.com/quarto-dev/quarto-cli/issues/14741)): Don't wrap the `longtable` environment of a cross-referenceable table in a `{ ... }` group. Pandoc emits that group to scope its `\def\LTcaptype{none}`, which Quarto removes when adding its own `\caption`; keeping the now-pointless group broke packages that move the environment out of the text flow, such as `endfloat` with `\DeclareDelayedFloatFlavor*{longtable}{table}`.

## Accessibility

- ([#14615](https://github.com/quarto-dev/quarto-cli/issues/14615)): Fix invalid `role="menu"` on the website navbar's collapse toggle button, flagged by axe-core (`aria-allowed-role`) and WAVE (`aria_menu_broken`) when the navbar collapses to the hamburger at narrow viewports.

## Engines

### `knitr`
Expand Down
2 changes: 1 addition & 1 deletion src/resources/projects/website/templates/navtoggle.ejs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<button class="navbar-toggler" type="button" data-bs-toggle="collapse" data-bs-target="#navbarCollapse"
aria-controls="navbarCollapse" role="menu" aria-expanded="false" aria-label="<%- language['toggle-navigation'] %>"
aria-controls="navbarCollapse" aria-expanded="false" aria-label="<%- language['toggle-navigation'] %>"
onclick="if (window.quartoToggleHeadroom) { window.quartoToggleHeadroom(); }">
<span class="navbar-toggler-icon"></span>
</button>
3 changes: 3 additions & 0 deletions tests/docs/smoke-all/website/navbar-toggler-role/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
/.quarto/
/_site/
**/*.quarto_ipynb
11 changes: 11 additions & 0 deletions tests/docs/smoke-all/website/navbar-toggler-role/_quarto.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
project:
type: website

website:
title: "navbar-toggler-role"
navbar:
right:
- text: Home
href: index.qmd
- text: About
href: index.qmd
15 changes: 15 additions & 0 deletions tests/docs/smoke-all/website/navbar-toggler-role/index.qmd
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
title: "Home"
_quarto:
tests:
html:
ensureHtmlElements:
-
- 'button.navbar-toggler[aria-expanded][aria-controls][aria-label]'
-
- 'button.navbar-toggler[role]'
---

The navbar's collapse toggle button must keep its native button semantics:
no `role` override (`role="menu"` is invalid on a button — #14615), with
`aria-expanded`, `aria-controls`, and `aria-label` intact.
Loading