Conversation
- UI looks a bit better - moved styles to CSS (the other CSS)
Strilanc
left a comment
There was a problem hiding this comment.
I like the retina fixes and the dialog for the example circuits. But the other style changes seem sorta superfluous and appear to be breaking single-file-ness.
(Does hitting escape work for closing the dialog?)
glue/crumble/crumble.css
Outdated
| @@ -0,0 +1,82 @@ | |||
| body { | |||
There was a problem hiding this comment.
This looks like it's breaking the fact that crumble compiles into a single HTML file (e.g. so that it can be written to stdout which is then piped into a file which is then opened with a browser).
Inline the styles into the HTML file.
There was a problem hiding this comment.
Oh, cool. I didn't realize the inline style was intentional. Thought it only open as URL. will inline the styles, sure.
glue/crumble/crumble.css
Outdated
| padding-right: 5px; | ||
| } | ||
|
|
||
| button { |
There was a problem hiding this comment.
Why aren't we just using the default button style? I generally prefer to let each browser choose how widget should look.
There was a problem hiding this comment.
Just a matter of taste, I guess. I can remove the button style, but still leave the flexbox such that at least they align properly.
I like the escape idea - will implement that + inline styles and revert the button opinionated styling. |
…n between content and form
…ise canvas loses proportions)
Made some Crumble UI touchups:
After:

Before:
