Skip to content

Crumble UI touchups#1052

Open
DeDuckProject wants to merge 9 commits intoquantumlib:mainfrom
DeDuckProject:ui-touchups
Open

Crumble UI touchups#1052
DeDuckProject wants to merge 9 commits intoquantumlib:mainfrom
DeDuckProject:ui-touchups

Conversation

@DeDuckProject
Copy link
Copy Markdown
Contributor

@DeDuckProject DeDuckProject commented Apr 10, 2026

Made some Crumble UI touchups:

  • Fixed canvas blurriness which occurs on Retina display (and probably others)
  • example circuits open as modal instead of inline
  • html style extracted to CSS (the other CSS)
  • Small improvements to styling (mainly buttons)
  • main canvas size now dynamically calculated to fit screen (so no more scroll)

After:
Screenshot 2026-04-10 at 13 37 54

Before:
Screenshot 2026-04-10 at 13 38 03

@DeDuckProject DeDuckProject changed the title UI touchups Crumble UI touchups Apr 10, 2026
Copy link
Copy Markdown
Collaborator

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the retina fixes and the dialog for the example circuits. But the other style changes seem sorta superfluous and appear to be breaking single-file-ness.

(Does hitting escape work for closing the dialog?)

@@ -0,0 +1,82 @@
body {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's breaking the fact that crumble compiles into a single HTML file (e.g. so that it can be written to stdout which is then piped into a file which is then opened with a browser).

Inline the styles into the HTML file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, cool. I didn't realize the inline style was intentional. Thought it only open as URL. will inline the styles, sure.

padding-right: 5px;
}

button {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't we just using the default button style? I generally prefer to let each browser choose how widget should look.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a matter of taste, I guess. I can remove the button style, but still leave the flexbox such that at least they align properly.

@DeDuckProject
Copy link
Copy Markdown
Contributor Author

I like the retina fixes and the dialog for the example circuits. But the other style changes seem sorta superfluous and appear to be breaking single-file-ness.

(Does hitting escape work for closing the dialog?)

I like the escape idea - will implement that + inline styles and revert the button opinionated styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants