-
Notifications
You must be signed in to change notification settings - Fork 415
Move GitHub access token from query parameter into header #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mhucka
merged 10 commits into
quantumlib:main
from
mhucka:security-fix-github-token-10096806154113847228
Apr 23, 2026
+44
−6
Merged
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ee6f9cf
Move GitHub access token from query parameter to Authorization header.
mhucka f58709d
Merge branch 'main' into security-fix-github-token-10096806154113847228
mhucka 8ab3a43
Format
mhucka 5f27e24
Handle case of actual_commit_id == None
mhucka 4f04743
Provide a timeout
mhucka 4e5e214
Merge branch 'main' into security-fix-github-token-10096806154113847228
mhucka 7f02a9e
Update dev_tools/prepared_env.py
mhucka 397ee63
Update dev_tools/prepared_env_security_test.py
mhucka 55d810a
Merge branch 'main' into security-fix-github-token-10096806154113847228
mhucka 00420be
Merge branch 'main' into security-fix-github-token-10096806154113847228
mhucka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import unittest | ||
| from unittest.mock import patch, MagicMock | ||
| from dev_tools.prepared_env import PreparedEnv | ||
| from dev_tools.github_repository import GithubRepository | ||
|
|
||
|
|
||
| class TestPreparedEnvSecurity(unittest.TestCase): | ||
| @patch('requests.post') | ||
| def test_report_status_to_github_token_in_header(self, mock_post): | ||
| # Setup | ||
| mock_response = MagicMock() | ||
| mock_response.status_code = 201 | ||
| mock_post.return_value = mock_response | ||
|
|
||
| repo = GithubRepository('my-org', 'my-repo', 'my-token') | ||
| env = PreparedEnv(repo, 'my-commit', 'compare-commit', None, None) | ||
|
|
||
| # Execute | ||
| env.report_status_to_github('success', 'desc', 'ctx') | ||
|
|
||
| # Verify | ||
| args, kwargs = mock_post.call_args | ||
| url = args[0] | ||
| headers = kwargs.get('headers', {}) | ||
|
|
||
| # Security check: Token should NOT be in the URL | ||
| self.assertNotIn('access_token=my-token', url, "Token should not be passed in the URL") | ||
|
|
||
| # Security check: Token should be in the Authorization header | ||
| self.assertEqual( | ||
| headers.get('Authorization'), | ||
| 'token my-token', | ||
|
mhucka marked this conversation as resolved.
Outdated
|
||
| "Token should be passed in the Authorization header", | ||
| ) | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| unittest.main() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.