Skip to content

Add pull-request note for the first-time contributors#8016

Merged
pavoljuhas merged 3 commits intoquantumlib:mainfrom
pavoljuhas:first-time-user-comment
Apr 15, 2026
Merged

Add pull-request note for the first-time contributors#8016
pavoljuhas merged 3 commits intoquantumlib:mainfrom
pavoljuhas:first-time-user-comment

Conversation

@pavoljuhas
Copy link
Copy Markdown
Collaborator

Here is a text for the initial response to first-time contributors
asking them to perform local testing of their PR. It is hoped that
this process would encourage a due level of attention to the
correctness and quality of proposed changes.

Here is a draft of the initial response to first-time contributors
asking them to perform local testing of their PR.  It is hoped that
this process would encourage a due level of attention to the
correctness and quality of proposed changes.
@github-actions github-actions bot added the size: S 10< lines changed <50 label Apr 3, 2026
@pavoljuhas pavoljuhas requested a review from mhucka April 3, 2026 19:34
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.63%. Comparing base (5975e16) to head (cdb60b3).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8016   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        1110     1110           
  Lines       99749    99755    +6     
=======================================
+ Hits        99386    99394    +8     
+ Misses        363      361    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread .github/PR_TEMPLATE/first_time_contributor.md Outdated
Comment thread .github/PR_TEMPLATE/first_time_contributor.md Outdated
Comment thread .github/PR_TEMPLATE/first_time_contributor.md Outdated
Comment thread .github/PR_TEMPLATE/first_time_contributor.md Outdated
Comment thread .github/PR_TEMPLATE/first_time_contributor.md Outdated
Comment thread .github/PR_TEMPLATE/first_time_contributor.md Outdated
Comment thread .github/PR_TEMPLATE/first_time_contributor.md Outdated
pavoljuhas and others added 2 commits April 6, 2026 12:09
Co-authored-by: Michael Hucka <mhucka@google.com>
Copy link
Copy Markdown
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable counter-measure to me.

@mhucka
Copy link
Copy Markdown
Contributor

mhucka commented Apr 14, 2026

@dstrain115 Thanks for reviewing it. Just in case it was missed: this is still a draft PR. We will probably do this, but are still discussing this and other possible measures.

@pavoljuhas pavoljuhas marked this pull request as ready for review April 14, 2026 20:28
@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners April 14, 2026 20:28
@pavoljuhas pavoljuhas requested a review from maffoo April 14, 2026 20:28
@pavoljuhas
Copy link
Copy Markdown
Collaborator Author

pavoljuhas commented Apr 14, 2026

@mhucka - FYI, I just discussed this with Doug so that's how it got reviewed. Would you mind if we merge this and start testing this approach with new contributors?
(If you feel the note should be placed at a better path I am all for that.)

@mhucka
Copy link
Copy Markdown
Contributor

mhucka commented Apr 14, 2026

@mhucka - FYI, I just discussed this with Doug so that's how it got reviewed. Would you mind if we merge this and start testing this approach with new contributors? (If you feel the note should be placed at a better path I am all for that.)

OK, yes, let's go ahead. IMHO something like this PR is good to do in any case.

@pavoljuhas pavoljuhas added this pull request to the merge queue Apr 14, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2026
@pavoljuhas pavoljuhas added this pull request to the merge queue Apr 15, 2026
@pavoljuhas pavoljuhas added ci/no-release Use this label for pull request that should not have Cirq pre-release on PyPI. labels Apr 15, 2026
Merged via the queue into quantumlib:main with commit b3366ab Apr 15, 2026
41 checks passed
@pavoljuhas pavoljuhas deleted the first-time-user-comment branch April 15, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/no-release Use this label for pull request that should not have Cirq pre-release on PyPI. size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants