Add pull-request note for the first-time contributors#8016
Add pull-request note for the first-time contributors#8016pavoljuhas merged 3 commits intoquantumlib:mainfrom
Conversation
Here is a draft of the initial response to first-time contributors asking them to perform local testing of their PR. It is hoped that this process would encourage a due level of attention to the correctness and quality of proposed changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8016 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 1110 1110
Lines 99749 99755 +6
=======================================
+ Hits 99386 99394 +8
+ Misses 363 361 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Michael Hucka <mhucka@google.com>
No change in content.
dstrain115
left a comment
There was a problem hiding this comment.
Seems like a reasonable counter-measure to me.
|
@dstrain115 Thanks for reviewing it. Just in case it was missed: this is still a draft PR. We will probably do this, but are still discussing this and other possible measures. |
|
@mhucka - FYI, I just discussed this with Doug so that's how it got reviewed. Would you mind if we merge this and start testing this approach with new contributors? |
OK, yes, let's go ahead. IMHO something like this PR is good to do in any case. |
Here is a text for the initial response to first-time contributors
asking them to perform local testing of their PR. It is hoped that
this process would encourage a due level of attention to the
correctness and quality of proposed changes.