fix: resolve all test failures and type errors across api and shared packages#37
Open
stooit wants to merge 1 commit into
Open
fix: resolve all test failures and type errors across api and shared packages#37stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…packages - Import missing badRequest helper in users route handler - Fix User type field name (userName → username) in shared types - Fix auth middleware case-sensitivity bug (POST method matching) - Implement paginate utility function in shared package - Add node types to tsconfig for process.env references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
badRequestimport in the users route handler (packages/api/src/routes/users.ts)Usertype field name fromuserNametousernamein shared types (packages/shared/src/types.ts)POSTconsistently (packages/api/src/middleware/auth.ts)paginateutility function that was previously a stub (packages/shared/src/utils/pagination.ts)@types/nodeto tsconfig types forprocess.envreferencesVerification
All 22 tests pass and
tsc --noEmitreports 0 type errors.Assumptions
Usertype's field should beusername(matching the test expectations and API usage) rather thanuserName